chore(server): Fix modernize linter (#26324)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

server/application/logs.go

@@ -44,7 +44,7 @@ func parseLogsStream(podName string, stream io.ReadCloser, ch chan logEntry) {
 		}
 
 		lines := strings.Join(parts[1:], " ")
-		for _, line := range strings.Split(lines, "\r") {
+		for line := range strings.SplitSeq(lines, "\r") {
 			ch <- logEntry{line: line, timeStamp: logTime, podName: podName}
 		}
 	}

server/applicationset/applicationset.go

@@ -278,7 +278,7 @@ func (s *Server) updateAppSet(ctx context.Context, appset *v1alpha1.ApplicationS
 		}
 	}
 
-	for i := 0; i < 10; i++ {
+	for range 10 {
 		appset.Spec = newAppset.Spec
 		if merge {
 			appset.Labels = collections.Merge(appset.Labels, newAppset.Labels)

server/cluster/cluster_test.go

@@ -682,8 +682,6 @@ func TestListCluster(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
-
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

server/extension/extension_test.go

@@ -210,7 +210,6 @@ func TestRegisterExtensions(t *testing.T) {
 
 		// when
 		for _, tc := range cases {
-			tc := tc
 			t.Run(tc.name, func(t *testing.T) {
 				// given
 				t.Parallel()

server/project/project.go

@@ -547,7 +547,7 @@ func (s *Server) NormalizeProjs() error {
 		return status.Errorf(codes.Internal, "Error retrieving project list: %s", err.Error())
 	}
 	for _, proj := range projList.Items {
-		for i := 0; i < 3; i++ {
+		for i := range 3 {
 			if !proj.NormalizeJWTTokens() {
 				break
 			}

server/server_norace_test.go

@@ -1,5 +1,4 @@
 //go:build !race
-// +build !race
 
 package server
 

server/session/ratelimiter_test.go

@@ -13,7 +13,7 @@ import (
 func TestRateLimiter(t *testing.T) {
 	var closers []utilio.Closer
 	limiter := NewLoginRateLimiter(10)
-	for i := 0; i < 10; i++ {
+	for range 10 {
 		closer, err := limiter()
 		require.NoError(t, err)
 		closers = append(closers, closer)