fix(discovery): add missing lua syntax and return to discovery (fixes #24257) (#24262)

Signed-off-by: jan-mrm <67435696+jan-mrm@users.noreply.github.com>

resource_customizations/numaflow.numaproj.io/InterStepBufferService/actions/discovery.lua

@@ -15,4 +15,7 @@ end
 if forcePromote then
   actions["force-promote"]["disabled"] = false
 else
-  actions["force-promote"]["disabled"] = true
+  actions["force-promote"]["disabled"] = true
+end
+
+return actions

resource_customizations/numaflow.numaproj.io/MonoVertex/actions/action_test.yaml

@@ -10,4 +10,40 @@ actionTests:
   expectedOutputPath: testdata/monovertex-unpause-fast.yaml
 - action: force-promote
   inputPath: testdata/monovertex.yaml
-  expectedOutputPath: testdata/monovertex-force-promote.yaml
+  expectedOutputPath: testdata/monovertex-force-promote.yaml
+
+discoveryTests:
+  - inputPath: testdata/monovertex.yaml
+    result:
+      - name: pause
+        disabled: false
+        iconClass: 'fa-solid fa-fw fa-pause'
+      - name: unpause-gradual
+        disabled: true
+        iconClass: 'fa-solid fa-fw fa-play'
+        displayName: 'Unpause (gradual)'
+      - name: unpause-fast
+        disabled: true
+        iconClass: 'fa-solid fa-fw fa-play'
+        displayName: 'Unpause (fast)'
+      - name: force-promote
+        disabled: false
+        iconClass: 'fa-solid fa-fw fa-forward'
+        displayName: 'Force Promote'
+  - inputPath: testdata/monovertex-paused.yaml
+    result:
+      - name: pause
+        disabled: true
+        iconClass: 'fa-solid fa-fw fa-pause'
+      - name: unpause-gradual
+        disabled: false
+        iconClass: 'fa-solid fa-fw fa-play'
+        displayName: 'Unpause (gradual)'
+      - name: unpause-fast
+        disabled: true
+        iconClass: 'fa-solid fa-fw fa-play'
+        displayName: 'Unpause (fast)'
+      - name: force-promote
+        disabled: false
+        iconClass: 'fa-solid fa-fw fa-forward'
+        displayName: 'Force Promote'

resource_customizations/numaflow.numaproj.io/MonoVertex/actions/discovery.lua

@@ -54,4 +54,7 @@ end
 if forcePromote then
   actions["force-promote"]["disabled"] = false
 else
-  actions["force-promote"]["disabled"] = true
+  actions["force-promote"]["disabled"] = true
+end
+
+return actions

resource_customizations/numaflow.numaproj.io/Pipeline/actions/action_test.yaml

@@ -10,4 +10,40 @@ actionTests:
   expectedOutputPath: testdata/pipeline-unpause-fast.yaml
 - action: force-promote
   inputPath: testdata/pipeline.yaml
-  expectedOutputPath: testdata/pipeline-force-promote.yaml
+  expectedOutputPath: testdata/pipeline-force-promote.yaml
+
+discoveryTests:
+  - inputPath: testdata/pipeline.yaml
+    result:
+      - name: pause
+        disabled: false
+        iconClass: 'fa-solid fa-fw fa-pause'
+      - name: unpause-gradual
+        disabled: true
+        iconClass: 'fa-solid fa-fw fa-play'
+        displayName: 'Unpause (gradual)'
+      - name: unpause-fast
+        disabled: true
+        iconClass: 'fa-solid fa-fw fa-play'
+        displayName: 'Unpause (fast)'
+      - name: force-promote
+        disabled: false
+        iconClass: 'fa-solid fa-fw fa-forward'
+        displayName: 'Force Promote'
+  - inputPath: testdata/pipeline-paused.yaml
+    result:
+      - name: pause
+        disabled: true
+        iconClass: 'fa-solid fa-fw fa-pause'
+      - name: unpause-gradual
+        disabled: false
+        iconClass: 'fa-solid fa-fw fa-play'
+        displayName: 'Unpause (gradual)'
+      - name: unpause-fast
+        disabled: true
+        iconClass: 'fa-solid fa-fw fa-play'
+        displayName: 'Unpause (fast)'
+      - name: force-promote
+        disabled: false
+        iconClass: 'fa-solid fa-fw fa-forward'
+        displayName: 'Force Promote'

resource_customizations/numaflow.numaproj.io/Pipeline/actions/discovery.lua

@@ -54,4 +54,7 @@ end
 if forcePromote then
   actions["force-promote"]["disabled"] = false
 else
-  actions["force-promote"]["disabled"] = true
+  actions["force-promote"]["disabled"] = true
+end
+
+return actions