From bde6f667e18c863ccb1ae4b0489cbfe63bf3d0a0 Mon Sep 17 00:00:00 2001 From: Ekene Chris <82538756+Ekene-Chris@users.noreply.github.com> Date: Wed, 14 Jan 2026 14:54:34 +0100 Subject: [PATCH] fix: correct typos across codebase (#25959) Signed-off-by: Ekene Chris --- applicationset/generators/git.go | 2 +- docs/operator-manual/ingress.md | 2 +- gitops-engine/pkg/diff/diff_test.go | 2 +- gitops-engine/pkg/utils/kube/resource_ops.go | 2 +- resource_customizations/batch/CronJob/health.lua | 8 ++++---- resource_customizations/batch/CronJob/health_test.yaml | 2 +- .../edit-notification-subscriptions.tsx | 2 +- .../components/account-details/account-details.tsx | 2 +- util/db/cluster_test.go | 4 ++-- util/git/creds.go | 6 +++--- util/settings/settings_test.go | 4 ++-- 11 files changed, 18 insertions(+), 18 deletions(-) diff --git a/applicationset/generators/git.go b/applicationset/generators/git.go index 76cc557f38..cb9f4c8d47 100644 --- a/applicationset/generators/git.go +++ b/applicationset/generators/git.go @@ -316,7 +316,7 @@ func (g *GitGenerator) filterApps(directories []argoprojiov1alpha1.GitDirectoryG appExclude = true } } - // Whenever there is a path with exclude: true it wont be included, even if it is included in a different path pattern + // Whenever there is a path with exclude: true it won't be included, even if it is included in a different path pattern if appInclude && !appExclude { res = append(res, appPath) } diff --git a/docs/operator-manual/ingress.md b/docs/operator-manual/ingress.md index 0f967676f9..921c242dd0 100644 --- a/docs/operator-manual/ingress.md +++ b/docs/operator-manual/ingress.md @@ -415,7 +415,7 @@ apiVersion: v1 kind: Service metadata: annotations: - alb.ingress.kubernetes.io/backend-protocol-version: GRPC # This tells AWS to send traffic from the ALB using GRPC. Plain HTTP2 can be used, but the health checks wont be available because argo currently downgrade non-grpc calls to HTTP1 + alb.ingress.kubernetes.io/backend-protocol-version: GRPC # This tells AWS to send traffic from the ALB using GRPC. Plain HTTP2 can be used, but the health checks won't be available because argo currently downgrades non-grpc calls to HTTP1 labels: app: argogrpc name: argogrpc diff --git a/gitops-engine/pkg/diff/diff_test.go b/gitops-engine/pkg/diff/diff_test.go index 97bc1a732a..674fa48ecc 100644 --- a/gitops-engine/pkg/diff/diff_test.go +++ b/gitops-engine/pkg/diff/diff_test.go @@ -704,7 +704,7 @@ func TestNullSecretData(t *testing.T) { } // TestRedactedSecretData tests we are able to perform diff on redacted secret data, which has -// invalid characters (*) for the the data byte array field. +// invalid characters (*) for the data byte array field. func TestRedactedSecretData(t *testing.T) { configUn := unmarshalFile("testdata/wordpress-config.json") liveUn := unmarshalFile("testdata/wordpress-live.json") diff --git a/gitops-engine/pkg/utils/kube/resource_ops.go b/gitops-engine/pkg/utils/kube/resource_ops.go index c4dba536fb..5782a3b465 100644 --- a/gitops-engine/pkg/utils/kube/resource_ops.go +++ b/gitops-engine/pkg/utils/kube/resource_ops.go @@ -119,7 +119,7 @@ func (k *kubectlResourceOperations) runResourceCommand(ctx context.Context, obj defer io.DeleteFile(manifestFile.Name()) var out []string - // rbac resouces are first applied with auth reconcile kubectl feature. + // rbac resources are first applied with auth reconcile kubectl feature. if obj.GetAPIVersion() == "rbac.authorization.k8s.io/v1" { outReconcile, err := k.rbacReconcile(ctx, obj, manifestFile.Name(), dryRunStrategy) if err != nil { diff --git a/resource_customizations/batch/CronJob/health.lua b/resource_customizations/batch/CronJob/health.lua index 44e69d4e2c..691491b256 100644 --- a/resource_customizations/batch/CronJob/health.lua +++ b/resource_customizations/batch/CronJob/health.lua @@ -1,7 +1,7 @@ hs = {} if obj.spec.suspend == true then - -- Set to Healthy insted of Suspended until bug is resolved + -- Set to Healthy instead of Suspended until bug is resolved -- See https://github.com/argoproj/argo-cd/issues/24428 hs.status = "Healthy" hs.message = "CronJob is Suspended" @@ -13,15 +13,15 @@ if obj.status ~= nil then -- Job is running its first execution and has not yet reported any success if obj.status.lastSuccessfulTime == nil then - -- Set to healthy even if it may be degraded, because we dont know + -- Set to healthy even if it may be degraded, because we don't know -- if it was not yet executed or if it never succeeded hs.status = "Healthy" - hs.message = "The Cronjob never completed succesfully. It may not be healthy" + hs.message = "The CronJob never completed successfully. It may not be healthy" return hs end - -- Job is progressing, so lastScheduleTime will always be grater than lastSuccessfulTime + -- Job is progressing, so lastScheduleTime will always be greater than lastSuccessfulTime -- Set to healthy since we do not know if it is Degraded -- See https://github.com/argoproj/argo-cd/issues/24429 if obj.status.active ~= nil and table.getn(obj.status.active) > 0 then diff --git a/resource_customizations/batch/CronJob/health_test.yaml b/resource_customizations/batch/CronJob/health_test.yaml index 04008a590b..0d179d39d7 100644 --- a/resource_customizations/batch/CronJob/health_test.yaml +++ b/resource_customizations/batch/CronJob/health_test.yaml @@ -13,7 +13,7 @@ tests: inputPath: testdata/degraded.yaml - healthStatus: status: Healthy - message: The Cronjob never completed succesfully. It may not be healthy + message: The CronJob never completed successfully. It may not be healthy inputPath: testdata/never-succeeded.yaml - healthStatus: status: Healthy diff --git a/ui/src/app/applications/components/application-summary/edit-notification-subscriptions.tsx b/ui/src/app/applications/components/application-summary/edit-notification-subscriptions.tsx index 771204edc0..9f4e98b73d 100644 --- a/ui/src/app/applications/components/application-summary/edit-notification-subscriptions.tsx +++ b/ui/src/app/applications/components/application-summary/edit-notification-subscriptions.tsx @@ -53,7 +53,7 @@ export const notificationSubscriptionsParser = { }; /** - * split the notification subscription related annotation to have it in seperate edit field + * split the notification subscription related annotation to have it in separate edit field * this hook will emit notification subscription state, controller & merge utility to core annotations helpful when final submit */ export const useEditNotificationSubscriptions = (annotations: models.Application['metadata']['annotations']) => { diff --git a/ui/src/app/settings/components/account-details/account-details.tsx b/ui/src/app/settings/components/account-details/account-details.tsx index 9e59c1b856..e810d36081 100644 --- a/ui/src/app/settings/components/account-details/account-details.tsx +++ b/ui/src/app/settings/components/account-details/account-details.tsx @@ -134,7 +134,7 @@ export const AccountDetails = (props: RouteComponentProps<{name: string}>) => { } } catch (e) { ctx.notifications.show({ - content: , + content: , type: NotificationType.Error }); } diff --git a/util/db/cluster_test.go b/util/db/cluster_test.go index b564081143..e78ebaa299 100644 --- a/util/db/cluster_test.go +++ b/util/db/cluster_test.go @@ -710,7 +710,7 @@ func TestClusterRaceConditionClusterSecrets(t *testing.T) { cluster, _ := SecretToCluster(clusterSecret) go func() { for { - // create a copy so we dont act on the same argo cluster + // create a copy so we don't act on the same argo cluster clusterCopy := cluster.DeepCopy() _, _ = db.UpdateCluster(ctx, clusterCopy) } @@ -718,7 +718,7 @@ func TestClusterRaceConditionClusterSecrets(t *testing.T) { // yes, we will take 15 seconds to run this test // but it reliably triggered the race condition for i := 0; i < 30; i++ { - // create a copy so we dont act on the same argo cluster + // create a copy so we don't act on the same argo cluster clusterCopy := cluster.DeepCopy() _, _ = db.UpdateCluster(ctx, clusterCopy) time.Sleep(time.Millisecond * 500) diff --git a/util/git/creds.go b/util/git/creds.go index 130f6df7d2..4e64c5e476 100644 --- a/util/git/creds.go +++ b/util/git/creds.go @@ -535,7 +535,7 @@ func (g GitHubAppCreds) getInstallationTransport() (*ghinstallation.Transport, e h := sha256.New() _, err := fmt.Fprintf(h, "%s %d %d %s", g.privateKey, g.appID, g.appInstallId, g.baseURL) if err != nil { - return nil, fmt.Errorf("failed to get get SHA256 hash for GitHub app credentials: %w", err) + return nil, fmt.Errorf("failed to get SHA256 hash for GitHub app credentials: %w", err) } key := hex.EncodeToString(h.Sum(nil)) @@ -878,7 +878,7 @@ func (c GoogleCloudCreds) getAccessToken() (string, error) { token, err := ts.Token() if err != nil { - return "", fmt.Errorf("failed to get get SHA256 hash for Google Cloud credentials: %w", err) + return "", fmt.Errorf("failed to get SHA256 hash for Google Cloud credentials: %w", err) } return token.AccessToken, nil @@ -923,7 +923,7 @@ func (creds AzureWorkloadIdentityCreds) getAccessToken(scope string) (string, er // Compute hash of creds for lookup in cache key, err := argoutils.GenerateCacheKey("%s", scope) if err != nil { - return "", fmt.Errorf("failed to get get SHA256 hash for Azure credentials: %w", err) + return "", fmt.Errorf("failed to get SHA256 hash for Azure credentials: %w", err) } t, found := azureTokenCache.Get(key) diff --git a/util/settings/settings_test.go b/util/settings/settings_test.go index 5ed9700661..fa6b3d64f6 100644 --- a/util/settings/settings_test.go +++ b/util/settings/settings_test.go @@ -2132,7 +2132,7 @@ func TestIsImpersonationEnabled(t *testing.T) { settingsManager := NewSettingsManager(t.Context(), kubeClient, "default") featureFlag, err := settingsManager.IsImpersonationEnabled() require.False(t, featureFlag, - "with no argocd-cm config map, IsImpersonationEnabled() must return return false (default value)") + "with no argocd-cm config map, IsImpersonationEnabled() must return false (default value)") require.ErrorContains(t, err, "configmap \"argocd-cm\" not found", "with no argocd-cm config map, IsImpersonationEnabled() must return an error") @@ -2175,7 +2175,7 @@ func TestRequireOverridePrivilegeForRevisionSyncNoConfigMap(t *testing.T) { settingsManager := NewSettingsManager(t.Context(), kubeClient, "default") featureFlag, err := settingsManager.RequireOverridePrivilegeForRevisionSync() require.False(t, featureFlag, - "with no argocd-cm config map, RequireOverridePrivilegeForRevisionSync() must return return false (default value)") + "with no argocd-cm config map, RequireOverridePrivilegeForRevisionSync() must return false (default value)") require.ErrorContains(t, err, "configmap \"argocd-cm\" not found", "with no argocd-cm config map, RequireOverridePrivilegeForRevisionSync() must return an error") }