marcel/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd.git synced 2026-02-20 01:28:45 +01:00
Code Issues Packages Projects Releases Wiki Activity
10,074 Commits 793 Branches 548 Tags
master
Commit Graph

93 Commits

Author SHA1 Message Date
rumstead
f83906d877 feat(appset): optimize appset controller performance when grabbing cluster secrets (#25624) (#25577) 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
 2026-01-12 18:37:48 -05:00
Michael Crenshaw
e77acec858 feat: allow limiting clusterResourceWhitelist by resource name (#12208) (#24674) 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
 2025-12-03 20:55:28 +00:00
Yann Soubeyrand
d6efb9e538 chore: move OIDC PKCE support from UI to backend (#21729) 
Signed-off-by: Yann Soubeyrand <8511577+yann-soubeyrand@users.noreply.github.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
 2025-06-17 18:18:24 +00:00
Matthieu MOREL
79c75876a8 chore(lint): enable httpNoBody rule from go-critic (#23399) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-06-15 16:11:38 -04:00
Michael Crenshaw
2bf3f6850e chore(lint): enable more gocritic linters (#23328) 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2025-06-11 23:50:02 -04:00
Michael Crenshaw
0fa3c3d67d chore(lint): enable tparallel linter (#23318) 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2025-06-08 15:10:55 +02:00
Michael Crenshaw
30a0088c84 chore: enable lint for unused private fields (#23242) 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2025-06-05 07:47:55 -04:00
Michael Crenshaw
5509dd8646 test(server): handle string groups claim (#22973) (#23208) 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2025-05-29 20:17:20 +00:00
Michael Crenshaw
76a63a1cac feat(api): protect static assets endpoint from symlink traversal (#22936) 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2025-05-13 16:43:14 -04:00
Michael Crenshaw
0ec46f6857 chore(ci): upgrade golangci-lint to v2 (#22484) 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2025-03-27 12:37:52 -04:00
sivchari
922d080ae5 chore: upgrade Go to 1.24 (#22242) 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
 2025-03-10 10:14:41 -04:00
Alexandre Gaudreault
e784c47667 chore(deps): bump go 1.23.5 & tools (#21748) 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
 2025-02-25 17:04:57 +00:00
Matthieu MOREL
c1b2f78f46 chore: enable var-naming from revive (#21861) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-02-18 11:02:38 -05:00
Atif Ali
85c6d267ba fix: override sub with federated_claims.user_id when dex is used (#20683) 
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
 2025-01-30 10:06:36 -05:00
Matthieu MOREL
5ef4faa8a4 chore: enable nolintlint (#21559) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-01-21 13:49:14 -05:00
github-actions[bot]
4d9835927d Bump major version to 3 (#21410) 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: crenshaw-dev <350466+crenshaw-dev@users.noreply.github.com>
 2025-01-10 16:14:00 -05:00
Matthieu MOREL
53bc19b5f2 chore: enable unused-parameter from revive (#21365) 
* chore: enable unused-parameter from revive

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* apply recommandations

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-01-07 10:12:56 -05:00
Matthieu MOREL
c80325737e chore: enable duplicated-imports from revive (#21378) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-01-06 11:34:32 -05:00
Matthieu MOREL
9ea979bbcd chore: enable use-any from revive (#21282) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-01-02 18:26:59 -05:00
Matthieu MOREL
6087b4f903 chore: use github.com/golang-jwt/jwt/v5 (#21276) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-01-02 18:23:28 -05:00
Matthieu MOREL
f245e8beb5 chore: enable err-error and strconcat of perfsprint linter (#21267) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-12-20 16:22:28 +00:00
Andrii Korotkov
45e488657b chore: Graceful shutdown for API Server (#18642) (#21224) 
* fix: Graceful shutdown for the API server (#18642) (#20981)

* fix: Graceful shutdown for the API server (#18642)

Closes #18642

Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* Init server only once, but keep re-initializing listeners

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Check error for SetParamInSettingConfigMap as needed after fresh master

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Prevent a data race

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Remove unused variable, don't pass lock when not necessary

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Try overriding URL instead of additional URLs

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Use a more specific url

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

---------

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* Use a custom signal for graceful restart

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Re-run tests

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

---------

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2024-12-17 16:51:18 -05:00
Pasha Kostohrys
46bfc10e4d Revert "fix: Graceful shutdown for the API server (#18642) (#20981)" (#21221) 2024-12-17 18:56:00 +02:00
Michael Crenshaw
5cdb1a0a15 chore: use new fake k8s client constructor (#21186) 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2024-12-16 14:49:30 +05:30
Andrii Korotkov
730363f14b fix: Graceful shutdown for the API server (#18642) (#20981) 
* fix: Graceful shutdown for the API server (#18642)

Closes #18642

Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* Init server only once, but keep re-initializing listeners

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Check error for SetParamInSettingConfigMap as needed after fresh master

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Prevent a data race

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Remove unused variable, don't pass lock when not necessary

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Try overriding URL instead of additional URLs

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

* Use a more specific url

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

---------

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2024-12-03 15:32:26 -05:00
Matthieu MOREL
cc989251ef chore: enable thelper linter (#20405) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-10-16 17:37:03 +00:00
Matthieu MOREL
e0ebb02443 chore: enable usestdlibvars linter (#20399) 2024-10-16 07:54:00 -04:00
Alexandre Gaudreault
70755aa3c5 feat(cli): add cmd to preview generated apps of appsets (#10895) (#16781) 
* feat(cli): add cmd to preview generated apps

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* fix build

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* fix local proto gen

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* dry run client

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* fix: allow to run codegen outside GOPATH

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* clientgen

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* openapigen

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* remove ensure-gopath

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* fix tests and templatePatch

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* fix build

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* convert to interfaces

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>

* codegen

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* extract common code

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* use appset params in server

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* codegen

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix test build

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* unit tests

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* move test to new package

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* move to correct folders

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix build

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* review

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* lint

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix test

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix lint

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* auto generate mocks

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* better error handling

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* more docs

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* more docs

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* lint

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2024-06-18 15:15:12 +00:00
Matthieu MOREL
c556cf7ea5 chore: enable require-error rule from errorlint linter on server folder (#18687) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-15 19:13:40 -04:00
Matthieu MOREL
7cf5ed06d4 chore: enable gofumpt and whitespace linters (#18567) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-11 15:41:55 +00:00
Matthieu MOREL
4a01f8a69a chore: enable expected-actual rule from testifylint linter (#18575) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-10 20:33:00 +00:00
Matthieu MOREL
32519c70a5 chore: enable error-nil rule from testifylint linter (#18544) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-10 10:38:55 -04:00
Matthieu MOREL
44b8dc1a4c chore: enable len and empty rules from testifylint linter (#18516) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-07 15:12:50 -04:00
Matthieu MOREL
71e1f30741 fix: enable bool-compare rule from testifylint linter (#18414) 2024-06-05 18:13:45 -04:00
Michael Crenshaw
8932036d53 fix(server): allow disabling content-type check (#16959) 
* fix(server): allow disabling content-type check

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix spacing

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2024-01-24 14:45:09 -05:00
Nathanael Liechti
819f0b3e87 feat(oidc): optionally query OIDC UserInfo to gather group claims (#12062) 
Signed-off-by: Nathanael Liechti <technat@technat.ch>
 2023-11-21 10:16:50 -05:00
Scott Windsor
da84f9e5be fix: Cache control 404 asset requests (#15327) 
* backfill cache control header tests for ui assets

Signed-off-by: Scott Windsor <scott.windsor@flexe.com>

* Set cache-control header non-cache for assets not found

Signed-off-by: Scott Windsor <scott.windsor@flexe.com>

* fix golang-cilint warning

Signed-off-by: Scott Windsor <scott.windsor@flexe.com>

---------

Signed-off-by: Scott Windsor <scott.windsor@flexe.com>
 2023-09-05 17:41:33 -04:00
Eng Zer Jun
e8331b4d12 chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml (#13292) 
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2023-05-04 18:06:56 -04:00
Fish-pro
c85902c999 chore: use http constants instead of string (#12334) 
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
 2023-02-17 14:04:10 -05:00
Michael Crenshaw
b38bc0040b Merge pull request from GHSA-q9hr-j4rf-8fjc 
* fix: verify audience claim

Co-Authored-By: Vladimir Pouzanov <farcaller@gmail.com>
Signed-off-by: CI <350466+crenshaw-dev@users.noreply.github.com>

* fix lint

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix handling of expired token error

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* go mod tidy

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* handle single aud claim marshaled as a string

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: CI <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Vladimir Pouzanov <farcaller@gmail.com>
 2023-01-25 09:15:03 -05:00
Pavel
37ad433759 feat: add notifications API (#10279) 
* add notifications API

we allow to list triggers, templates and services

Signed-off-by: Pavel <aborilov@gmail.com>

* fix: add notification manifest to tests

Signed-off-by: Pavel <aborilov@gmail.com>

* fix: add sleep to fix integration tests

for some reason notification configmap has old data, trying to fix with
the sleep

Signed-off-by: Pavel <aborilov@gmail.com>

* add proposal

Signed-off-by: Pavel <aborilov@gmail.com>

* more info to proposal

Signed-off-by: Pavel <aborilov@gmail.com>

* use struct for notifications objects instead of just strings

to be able easily extend API in the future return list of
trigger/template/service as list of structs

Signed-off-by: Pavel <aborilov@gmail.com>

Signed-off-by: Pavel <aborilov@gmail.com>
 2022-08-25 16:04:14 -07:00
Alexander Matyushentsev
ee7356a202 fix: make sure api server informer does not stop after setting change (#9842) 
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2022-06-30 22:28:52 +00:00
Alexander Matyushentsev
9d4c940a5a fix: avoid closing and re-opening port of api server settings change (#9778) 
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2022-06-23 14:30:39 -07:00
Soumya Ghosh Dastidar
952230eaf8 fix: updated baseHRefRegex to perform lazy match (#9724) 
* fix: updated baseHRefRegex to perform lazy match

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: added unit tests for replaceBaseHRef

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
 2022-06-20 15:52:33 -07:00
Michael Crenshaw
9d81222652 fix: missing Helm params (#9565) (#9566) 
* fix: missing Helm params

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* use absolute paths, fix tests

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* fix race in test

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
 2022-06-04 20:16:54 -04:00
Michael Crenshaw
4a51875179 fix: test race (#9469) 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
 2022-05-20 16:38:01 +00:00
Tommaso Sardelli
c2a9a7f5a1 chore: upgrade golangci-lint to v1.46.2 (#9448) 
* chore: upgrade golangci-lint to v1.46.2

Because:

* Installation of golangci-lint v1.45.2 is currently broken and fails
  silently due to a redacted dependency
  (https://github.com/blizzy78/varnamelen/issues/13)

This commit:

* Upgrades golangci-lint to v1.46.2

Signed-off-by: Tommaso Sardelli <lacapannadelloziotom@gmail.com>

* fix: lint

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* fix: lint

Signed-off-by: Tommaso Sardelli <lacapannadelloziotom@gmail.com>

Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
 2022-05-19 09:27:01 -04:00
Michael Crenshaw
fc077b14cd fix: lint (#9444) 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
 2022-05-18 18:50:20 +02:00
jannfis
a809469d9a Merge pull request from GHSA-r642-gv9p-2wjj 
Signed-off-by: jannfis <jann@mistrust.net>

Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>

Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
 2022-05-18 13:16:21 +02:00
Jonah Back
14cdfc77da feat: add caching to application js bundle since it has a unique name (#9008) 
* feat: add caching to application js bundle since it has a unique name

Signed-off-by: Jonah Back <jonah@jonahback.com>

* chore: simplify check and add tests

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
 2022-04-07 10:15:23 -04:00