Mike Cutsail
2793097480
feat: add OTEL instrumentation for authentication and handlers ( #25296 )
...
Signed-off-by: Mike Cutsail <mcutsail15@apple.com >
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com >
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com >
2026-02-10 13:31:55 +00:00
Matthieu MOREL
1b4398b5ba
chore(util): Fix modernize linter ( #26342 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-02-09 10:59:51 -05:00
Matthieu MOREL
a369ae2cf6
chore(util): Fix modernize linter ( #26300 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2026-02-06 17:17:17 -05:00
Mike Cutsail
5c6aa59ed3
feat: oidc background token refresh ( #23727 )
...
Signed-off-by: Mike Cutsail <mcutsail15@apple.com >
2025-11-13 11:37:53 -05:00
Nathanael Liechti
5efb184c79
fix(oidc): check userinfo endpoint in AuthMiddleware ( #23586 )
...
Signed-off-by: Nathanael Liechti <technat@technat.ch >
2025-10-06 09:22:47 -04:00
Matthieu MOREL
7357465ea6
chore: enable noctx linter ( #24765 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-09-29 20:20:53 +02:00
sathiya06
3401d3bf92
feat: Export metrics to track number of users ( #20801 ) ( #23343 )
...
Signed-off-by: Sathiya Narayanan Venkatesan <sathiyavenkat06@gmail.com >
Signed-off-by: sathiya06 <64639742+sathiya06@users.noreply.github.com >
2025-06-30 10:00:33 -07:00
Yann Soubeyrand
d6efb9e538
chore: move OIDC PKCE support from UI to backend ( #21729 )
...
Signed-off-by: Yann Soubeyrand <8511577+yann-soubeyrand@users.noreply.github.com >
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com >
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com >
2025-06-17 18:18:24 +00:00
Matthieu MOREL
ede2b32aea
chore(lint): enable ptrToRefParam rule from go-critic ( #23424 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-06-16 19:28:57 +00:00
Matthieu MOREL
79c75876a8
chore(lint): enable httpNoBody rule from go-critic ( #23399 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-06-15 16:11:38 -04:00
Michael Crenshaw
7915002382
fix(server): race condition in revoked token logic ( #23311 ) ( #23312 )
...
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
2025-06-06 16:49:59 -04:00
Michael Crenshaw
7fda067767
fix(server): avoid unnecessary claims restrictions ( #22973 ) ( #23202 )
...
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
2025-05-29 18:57:12 +00:00
Kanika Rana
e8f568a70d
chore: use name imports for argocd Utilio ( #22836 )
...
Signed-off-by: Kanika Rana <krana@redhat.com >
2025-05-21 16:25:32 +00:00
Seth Gupton
cde5b4b7d4
fix: Increase Scan count and move Scan outside of mutex lock to avoid slow calls timing out ( #17645 ) ( #21926 )
...
Signed-off-by: Seth Gupton <seth.gupton@mastery.net >
2025-04-10 14:08:21 -07:00
Michael Crenshaw
0ec46f6857
chore(ci): upgrade golangci-lint to v2 ( #22484 )
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-27 12:37:52 -04:00
sivchari
922d080ae5
chore: upgrade Go to 1.24 ( #22242 )
...
Signed-off-by: sivchari <shibuuuu5@gmail.com >
2025-03-10 10:14:41 -04:00
Andrii Korotkov
62ec9fef36
fix: Use t.Fatal instead of os.Exit in tests (part 2) ( #21003 ) ( #22187 )
...
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
2025-03-06 19:24:07 +00:00
Blake Pettersson
a1431bef4c
fix(ui, rbac): project-roles ( #21829 )
...
Signed-off-by: wyttime04 <vanessa80332@gmail.com >
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
Co-authored-by: wyttime04 <vanessa80332@gmail.com >
2025-02-20 11:40:15 +01:00
Matthieu MOREL
c1b2f78f46
chore: enable var-naming from revive ( #21861 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-02-18 11:02:38 -05:00
Matthieu MOREL
9843bfbdf8
chore: use testify instead of native testing ( #21781 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-02-05 09:46:52 -05:00
Atif Ali
85c6d267ba
fix: override sub with federated_claims.user_id when dex is used ( #20683 )
...
Signed-off-by: Atif Ali <atali@redhat.com >
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com >
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com >
2025-01-30 10:06:36 -05:00
Matthieu MOREL
27915da5b0
chore: enable singleCaseSwitch and commentFormatting rules from gocritic ( #21616 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-01-22 10:45:32 -05:00
Matthieu MOREL
5ef4faa8a4
chore: enable nolintlint ( #21559 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-01-21 13:49:14 -05:00
github-actions[bot]
4d9835927d
Bump major version to 3 ( #21410 )
...
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: crenshaw-dev <350466+crenshaw-dev@users.noreply.github.com >
2025-01-10 16:14:00 -05:00
Matthieu MOREL
53bc19b5f2
chore: enable unused-parameter from revive ( #21365 )
...
* chore: enable unused-parameter from revive
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* apply recommandations
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-01-07 10:12:56 -05:00
Matthieu MOREL
4e5db16fbf
chore: enable increment-decrement from revive ( #21366 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-01-03 22:45:03 +00:00
Matthieu MOREL
9ea979bbcd
chore: enable use-any from revive ( #21282 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-01-02 18:26:59 -05:00
Matthieu MOREL
6087b4f903
chore: use github.com/golang-jwt/jwt/v5 ( #21276 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-01-02 18:23:28 -05:00
Matthieu MOREL
8a6f53d044
chore: enable errorf of perfsprint linter ( #21280 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-12-30 10:56:41 +02:00
Matthieu MOREL
f245e8beb5
chore: enable err-error and strconcat of perfsprint linter ( #21267 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-12-20 16:22:28 +00:00
Andrii Korotkov
45e488657b
chore: Graceful shutdown for API Server ( #18642 ) ( #21224 )
...
* fix: Graceful shutdown for the API server (#18642 ) (#20981 )
* fix: Graceful shutdown for the API server (#18642 )
Closes #18642
Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating.
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* Init server only once, but keep re-initializing listeners
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Check error for SetParamInSettingConfigMap as needed after fresh master
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Prevent a data race
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Remove unused variable, don't pass lock when not necessary
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Try overriding URL instead of additional URLs
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Use a more specific url
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
---------
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* Use a custom signal for graceful restart
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Re-run tests
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
---------
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
2024-12-17 16:51:18 -05:00
Pasha Kostohrys
46bfc10e4d
Revert "fix: Graceful shutdown for the API server ( #18642 ) ( #20981 )" ( #21221 )
2024-12-17 18:56:00 +02:00
Michael Crenshaw
5cdb1a0a15
chore: use new fake k8s client constructor ( #21186 )
...
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
2024-12-16 14:49:30 +05:30
Joowon Lim
35c12d9486
chore: use %q to simplify fmt.Sprintf ( #21108 )
...
Signed-off-by: Joowon Lim <m4rinesnow34@gmail.com >
2024-12-09 13:52:32 -05:00
Andrii Korotkov
730363f14b
fix: Graceful shutdown for the API server ( #18642 ) ( #20981 )
...
* fix: Graceful shutdown for the API server (#18642 )
Closes #18642
Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating.
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* Init server only once, but keep re-initializing listeners
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Check error for SetParamInSettingConfigMap as needed after fresh master
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Prevent a data race
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Remove unused variable, don't pass lock when not necessary
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Try overriding URL instead of additional URLs
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
* Use a more specific url
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
---------
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com >
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
2024-12-03 15:32:26 -05:00
Matthieu MOREL
a6cce1d0b3
chore: use testify instead of testing.Fatal or testing.Error in util ( #20751 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-11-11 17:55:11 +02:00
Matthieu MOREL
2998687416
chore: enable perfsprint linter ( #20685 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-11-10 21:00:57 -05:00
Matthieu MOREL
e0ebb02443
chore: enable usestdlibvars linter ( #20399 )
2024-10-16 07:54:00 -04:00
Matthieu MOREL
1c6ec19a86
fix: use ErrorContains(t, err instead of Contains(t, err.Error() ( #20220 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-04 09:36:05 -04:00
Matthieu MOREL
c9ea5b13d2
chore: extend require-error rule from testifylint ( #18658 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-06-14 09:15:31 -04:00
Matthieu MOREL
9f1e2e8453
chore: enable gocritic linter ( #18633 )
...
* chore: enable gocritic linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update settings.go
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update app.go
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update grpcproxy.go
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update grpcproxy.go
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update util.go
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update server.go
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update app_management_ns_test.go
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update app_management_test.go
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update path_traversal.go
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update sessionmanager.go
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update .golangci.yaml
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-06-13 15:10:00 -04:00
Matthieu MOREL
7cf5ed06d4
chore: enable gofumpt and whitespace linters ( #18567 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-06-11 15:41:55 +00:00
Matthieu MOREL
d7e99224d4
chore: enable errorlint linter on util folder ( #18588 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-06-11 10:42:32 -04:00
Matthieu MOREL
32519c70a5
chore: enable error-nil rule from testifylint linter ( #18544 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-06-10 10:38:55 -04:00
Michael Crenshaw
852f744265
fix(api): respect all allowed audiences, regardless of check order ( #17876 )
...
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
2024-04-17 20:42:58 -04:00
Jann Fischer
d11e146ab5
chore: Fix linter issue with session manager ( #17597 )
...
Signed-off-by: jannfis <jann@mistrust.net >
2024-03-22 15:05:18 +00:00
jannfis
d69c61ae1a
Merge pull request from GHSA-6v85-wr92-q4p7
...
* fix: Fix concurrency issue in session manager
Signed-off-by: jannfis <jann@mistrust.net >
* Add note that modification to the map must be done in a thread safe manner
* chore: fix linter issues
Signed-off-by: pashakostohrys <pavel@codefresh.io >
---------
Signed-off-by: jannfis <jann@mistrust.net >
Signed-off-by: pashakostohrys <pavel@codefresh.io >
Co-authored-by: Dan Garfield <dan@codefresh.io >
Co-authored-by: pashakostohrys <pavel@codefresh.io >
2024-03-18 03:59:06 -04:00
pasha-codefresh
6596e088ac
Merge pull request from GHSA-2vgg-9h6w-m454
...
* feat: pick random user and exclude admin user and current user from deletion candidates
Signed-off-by: pashakostohrys <pavel@codefresh.io >
* feat: increase default max cache size
Signed-off-by: pashakostohrys <pavel@codefresh.io >
* add nil protection
Signed-off-by: pashakostohrys <pavel@codefresh.io >
* Update util/session/sessionmanager.go
Signed-off-by: Dan Garfield <dan@codefresh.io >
Signed-off-by: Dan Garfield <dan@codefresh.io >
* chore: fix linter issues
Signed-off-by: pashakostohrys <pavel@codefresh.io >
---------
Signed-off-by: pashakostohrys <pavel@codefresh.io >
Signed-off-by: Dan Garfield <dan@codefresh.io >
Co-authored-by: Dan Garfield <dan@codefresh.io >
2024-03-18 03:58:18 -04:00
Eng Zer Jun
03026997d1
chore: use t.Setenv to set env vars in tests ( #14377 )
...
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com >
2023-07-06 19:50:08 -04:00
Nolan Emirot
7b74e1993e
chore: update redis client to v9 ( #12746 )
...
* chore: update redis
Signed-off-by: emirot <emirot.nolan@gmail.com >
* chore: update redis
Signed-off-by: emirot <emirot.nolan@gmail.com >
* chore: update redis
Signed-off-by: emirot <emirot.nolan@gmail.com >
---------
Signed-off-by: emirot <emirot.nolan@gmail.com >
2023-03-08 09:42:10 -05:00