Alexander Matyushentsev
7c9bd2d2d3
feat: application resource deletion protection ( #20497 )
...
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
2024-10-24 00:08:24 -07:00
Kunho Lee
9b11b21f00
fix: check err before use schedule and duration ( #20043 )
...
* fix: check err before use schedule and duration
Signed-off-by: daengdaengLee <gunho1020@gmail.com >
* test: add tests for invalid schedule and duration
Signed-off-by: daengdaengLee <gunho1020@gmail.com >
* feat: change to return error when sync window is invalid
Signed-off-by: daengdaengLee <gunho1020@gmail.com >
* fix: use assert.Error or assert.NoError
Signed-off-by: daengdaengLee <gunho1020@gmail.com >
* fix: use require instead of assert
Signed-off-by: daengdaengLee <gunho1020@gmail.com >
---------
Signed-off-by: daengdaengLee <gunho1020@gmail.com >
2024-10-12 13:32:46 -04:00
ABBOUD Moncef
fe7771cc83
fix: handle incorrect cluster RESTconfig without panic ( #20150 )
...
Signed-off-by: cef <moncef.abboud95@gmail.com >
2024-10-06 17:55:26 +03:00
Alexander Matyushentsev
03a16099b0
fix: support managing cluster with multiple argocd instances and annotation based tracking ( #20222 )
...
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
2024-10-04 17:54:37 -07:00
Anand Francis Joseph
5f8de971c6
chore: Added unit tests and fix e2e tests for application sync decoupling feature ( #19966 )
...
* fixed doc comments and added unit tests
Signed-off-by: anandf <anjoseph@redhat.com >
* Added comments for the newly added unit tests
Signed-off-by: anandf <anjoseph@redhat.com >
* Refactored method name to deriveServiceAccountToImpersonate
Signed-off-by: anandf <anjoseph@redhat.com >
* Using const name in return value
Signed-off-by: anandf <anjoseph@redhat.com >
* Added unit tests for argocd proj add-destination-service-accounts
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed failing e2e tests
Signed-off-by: anandf <anjoseph@redhat.com >
* Fix linting errors
Signed-off-by: anandf <anjoseph@redhat.com >
* Using require package instead of assert and fixed code generation
Signed-off-by: anandf <anjoseph@redhat.com >
* Removed parallel execution of tests for sync with impersonate
Signed-off-by: anandf <anjoseph@redhat.com >
* Added err checks for glob validations
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed e2e tests for sync impersonation
Signed-off-by: anandf <anjoseph@redhat.com >
* Using consistently based expects in E2E tests
Signed-off-by: anandf <anjoseph@redhat.com >
* Added more unit tests and fixed go generate
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed failed lint errors, unit and e2e test failures
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed goimports linter issue
Signed-off-by: anandf <anjoseph@redhat.com >
* Added code comments and added few missing unit tests
Signed-off-by: anandf <anjoseph@redhat.com >
* Added missing unit test for GetDestinationServiceAccounts method
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed goimports formatting with local for project_test.go
Signed-off-by: anandf <anjoseph@redhat.com >
* Corrected typo in a field name additionalObjs
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed failing unit tests
Signed-off-by: anandf <anjoseph@redhat.com >
---------
Signed-off-by: anandf <anjoseph@redhat.com >
2024-10-03 07:37:50 -07:00
Anand Francis Joseph
1028808bb7
feat: Decoupling application sync using impersonation ( #17403 )
...
* Implementation of app sync with impersonation support
Signed-off-by: anandf <anjoseph@redhat.com >
* negation test
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com >
* Update doc comments to remove server name as its not supported.
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com >
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com >
* Update glob pattern check for matching destinations.
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com >
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com >
* Corrected the code comments for namespace field and destination matching logic
Signed-off-by: anandf <anjoseph@redhat.com >
* Added missing generated files
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed golint errors caused due to to gofumpt validations
Signed-off-by: anandf <anjoseph@redhat.com >
* Fix golint errors with unit test code
Signed-off-by: anandf <anjoseph@redhat.com >
* Updated the go import ordering with local packages at the end
Signed-off-by: anandf <anjoseph@redhat.com >
* Addressed review comments
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed ES lint error caused due to missing class
Signed-off-by: anandf <anjoseph@redhat.com >
* Updated the documentation to address the review comments
Signed-off-by: anandf <anjoseph@redhat.com >
* Simplified the sync code and improved logs and error handling
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed E2E tests to fail when no sa is configured
Signed-off-by: anandf <anjoseph@redhat.com >
* Updated help message generated for CLI commands
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed failing tests due to default service account not used for sync operation
Signed-off-by: anandf <anjoseph@redhat.com >
* Fixed the error message when sync fails due to no matching sa
Signed-off-by: anandf <anjoseph@redhat.com >
* Removed repeating logs and added impersonation fields to logger
Signed-off-by: anandf <anjoseph@redhat.com >
* Made changes in the proposal to match the behaviour when no matching sa is found
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com >
---------
Signed-off-by: anandf <anjoseph@redhat.com >
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com >
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com >
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com >
Co-authored-by: Mangaal <angommeeteimangaal@gmail.com >
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com >
2024-09-04 14:18:47 -04:00
Michael Crenshaw
6aa4de62c8
chore: remove unused params ( #19473 )
...
* chore: remove unused params
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* more
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
2024-08-15 07:29:51 -04:00
Matthieu MOREL
7cf5ed06d4
chore: enable gofumpt and whitespace linters ( #18567 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-06-11 15:41:55 +00:00
Jorge Turrado Ferrero
0e531c956e
feat(application-controller): Add support for rollback multi-source applications ( #14124 )
...
* feat(application-controller): Add support for rollback multi-source applications
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* regenerate codegen after rebase
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* fix tests
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* fix front linting
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* update test
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* update codegen
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* Update server/application/application.go
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com >
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es >
* apply feedback
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* fix errors
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* add support for switching between single and multi
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* fix dereference issue
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* remove unnecesary code
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* Rebase master
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl >
* fix style
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* fix reference
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
* add a comment
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl >
---------
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es >
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es >
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl >
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com >
2024-06-10 17:54:07 -04:00
Matthieu MOREL
33df2ce698
chore: enable goimports linter ( #18564 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-06-10 09:18:12 -04:00
Alexander Matyushentsev
44da2063c7
fix: fix calculating patch for respect ignore diff feature ( #17693 )
...
* test: unit test for respectIgnoreDifferences bug
Signed-off-by: Jesse Suen <jesse@akuity.io >
* test: simplify unit test
Signed-off-by: Jesse Suen <jesse@akuity.io >
* fix: fix calculating patch for respect ignore diff feature
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
---------
Signed-off-by: Jesse Suen <jesse@akuity.io >
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
Co-authored-by: Jesse Suen <jesse@akuity.io >
2024-04-03 22:56:59 +00:00
Charles Coupal-Jetté
295dff6a38
fix: Appcontroller respects sync windows ( #16492 )
...
* fix: Appcontroller keeps op running when denied by sync window
Signed-off-by: Charles Coupal-Jetté <charles.coupaljette@goto.com >
* fix: Update test name
Signed-off-by: Charles Coupal-Jetté <charles.coupaljette@goto.com >
---------
Signed-off-by: Charles Coupal-Jetté <charles.coupaljette@goto.com >
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com >
2024-03-26 08:45:35 -04:00
Sorav Kumar Sharma
93a668ac09
fix the typo ( #17116 )
2024-02-07 18:32:07 +05:30
Robin Lieb
0e67ed89ac
feat: add initiated by in history and rollback view ( #16654 )
...
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com >
2023-12-22 16:50:33 +00:00
Leonardo Luz Almeida
82ca7a7f9c
feat: Implement Server-Side Diff ( #13663 )
...
* feat: Implement Server-Side Diff
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* propagate the refreshtype to the diff config
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Create the serverSideDiff config
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* chore: add featureflag utility package
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* remove featureflag package
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* add param
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* make ssd configurable with app annotation
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* add server-side-diff flags
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* apply the same logic regardless of the refresh type
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* fix gitops-engine reference
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* address review comments
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Address review comments
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* docs: add docs related to server-side-diff
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* docs: update doc
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Add config to include mutation webhooks
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Address review comments
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* go mod update
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Add sdd cache test case
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* fix ssd cache unit test
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Update clidocs
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* update manifests
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Fix procfile
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* additional doc changes
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* update gitops-engine version
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
---------
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
2023-12-18 20:37:13 +00:00
Alexander Matyushentsev
dcc17f70bf
feat: PostDelete hook support ( #16595 )
...
* feat: PostDelete hooks support
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
---------
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
2023-12-18 08:40:23 -08:00
gdsoumya
be2a01c231
feat: grace period for repo errors to prevent aggressive unknown sync state ( #16085 )
...
* feat: added grace period for repo errors to prevent aggressive sync state unknowns
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com >
* feat: updated docs
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com >
* fix: e2e test
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com >
* feat: resolved review comments
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com >
* feat: update unit test
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com >
* fix: codegen
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com >
---------
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com >
Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com >
2023-11-02 11:51:16 -04:00
Blake Pettersson
aed1be6388
fix: update managed namespace metadata ( #13074 )
...
* fix: update managed namespace metadata
This commit fixes an issue where a namespace does not get updated
unless a sync is performed. Since the `managedNamespaceMetadata` is not
a part of the Application Git state, we need a way to force a sync once
the metadata has changed. In order to do that, we need to add state
to compare with.
Once a sync is performed, the `ManagedNamespaceMetadata` gets copied
to `SyncResult`, which will then be compared with on subsequent syncs.
If there's a mismatch between
`app.Spec.SyncPolicy.ManagedNamespaceMetadata` and
`app.Status.OperationState.SyncResult.ManagedNamespaceMetadata` we mark
the Application as `OutOfSync`.
Fixes #12661 .
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* fix: nil check
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* fix: allow empty apps to be updated
If an app is empty but still differs in terms of
`managedNamespaceMetadata`, it should still be kept up to date.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* test: add unit tests in appcontroller
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* fix: rebase
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* refactor: extract method
Consolidate checks to `app.HasChangedManagedNamespaceMetadata()`
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* chore: make codegen
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
---------
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
2023-05-19 09:55:08 -04:00
asingh
696631e69c
fix: Add more context to the sync failed message when resource kind doesn't exist ( #12980 )
...
* fix: add more context to k8s message
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com >
* fix: add more context to k8s message
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com >
* fix: add more context to k8s message
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com >
* fix: add more context to k8s message
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com >
* fix: add more context to k8s message
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com >
* fix: add more context to k8s message
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com >
* Update util/argo/argo.go
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com >
* Update util/argo/argo.go
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com >
* improvements, maybe
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* remove unnecessary end quote
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* avoid conflicts with other tests
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
---------
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com >
Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com >
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
2023-04-03 15:48:50 +00:00
Ishita Sequeira
c6fa942e94
feat: Multiple sources for applications ( #2789 ) ( #10432 )
...
* feat: support multiple sources for application
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
remove debug logging and unwanted code
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
fix lint and unit test errors
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
fix lint and unit test errors
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* fix bug introduced after rebase
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
executed make codegen
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* rebase with master
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
remove unwanted logging
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
fix ci failures
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* fix index out of bounds error
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* ui fixes
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev >
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* add revisions to SyncOperation for rollback
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* change Source to *ApplicationSource in ApplicationSpec
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* fix env variable read logic for ValueFiles
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* update multiple sources doc
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* add repository lock and checkout target revision
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
fix codegen
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* checkout all sources before generating manifest
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
generate mock reposerverclient
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* update logic for returning ManifestResponse to avoid nil pointer issues
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* fix nil reference and key mismatch bugs; add more logs (#6 )
* fix nil reference and key mismatch bugs; add more logs
* remove temporary comment
* addressed the lint failure and added chart to RefTargeRevisionMapping
* normalize git repo (#7 )
* do not leak lock releases
* prevent deadlock
* allow spec update
* move settings fetch outside loop
* cache busing
* return err instead of logging it
* no caching in test
* fix cache key marshaling
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Rebase with master
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* update grpc field numbers
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* path resolution tests (#12 )
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
do things in better ways
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
consolidate
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* add regex check for value of source.ref
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* add webhook tests
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
change Source to *ApplicationSource in ApplicationSpec
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
address PR comments
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
rebase with master
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
Retrigger CI pipeline
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
rebased with master
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* fix env variable read logic for ValueFiles
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
Address PR comments
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* add repository lock and checkout target revision
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
fix codegen
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* checkout all sources before generating manifest
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* generate mock reposerverclient
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* address comments
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* update logic for returning ManifestResponse to avoid nil pointer issues
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* fix nil reference and key mismatch bugs; add more logs (#6 )
* fix nil reference and key mismatch bugs; add more logs
* remove temporary comment
* addressed the lint failure and added chart to RefTargeRevisionMapping
* normalize git repo (#7 )
* do not leak lock releases
* prevent deadlock
* allow spec update
* move settings fetch outside loop
* cache busing
* return err instead of logging it
* no caching in test
* fix cache key marshaling
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Rebase with master
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* update grpc field numbers
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* add regex check for value of source.ref
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* Rebase with master
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* Added unit tests (#15 )
* add unit tests 1
* fix lint
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* fix application parameters tab, rebased UI changes, tests
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* More tests (#16 )
* more tests
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
fix lint error
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
Test get ref sources (#17 )
* test GetRefSources
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* fix lint
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Co-authored-by: ishitasequeira <ishiseq29@gmail.com >
GenerateManifests test (#18 )
* GenerateManifests test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Fix broken tests (#19 )
* fix broken tests
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Symlink test (#20 )
* check referenced sources for out-of-bounds symlinks
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* unlock the values file repo before doing a symlink check (#22 )
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* multi source docs (#21 )
* multi source docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* fix warning title
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* clarify
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* clarify
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
* add e2e tests for multiple sources and fix UI lint (#23 )
* add e2e tests for multiple sources and fix UI lint
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* add auto-sync and hard refresh to e2e tests
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* change refresh type to RefreshTypeNormal for e2e
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* update e2e testcase with helm data
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* add TestMultiSourceAppWithSourceOverride
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* add missing yaml file
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* rebase with master
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* rebase with master
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
* fix lint
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
Signed-off-by: ishitasequeira <ishiseq29@gmail.com >
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev >
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com >
2022-12-16 15:47:08 -05:00
Blake Pettersson
777302191f
feat: enable metadata to be set on namespaces ( #10672 )
...
* namespace labels
Signed-off-by: pashavictorovich <pavel@codefresh.io >
* create namespace should support annotations
Signed-off-by: pashavictorovich <pavel@codefresh.io >
* handle also modification hook
Signed-off-by: pashavictorovich <pavel@codefresh.io >
* regenerate entity on modify hook
Signed-off-by: pashavictorovich <pavel@codefresh.io >
* manifests
Signed-off-by: pashavictorovich <pavel@codefresh.io >
* feat: enable metadata to be set on namespaces
This builds upon the work that @pasha-codefresh did in #10288 .
The main differences between this PR and the previous one is that we use
SSA to diff between different versions of the namespace, as well as
having a slightly different API in gitops-engine for setting the
namespace modifier.
We now also set the ownership of the namespace in ArgoCD.
Closes #4628
Closes #6215
Closes #7799
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* fix: don't always track namespaces
For now, only allow namespaces managed with `managedNamespaceMetadata`
to have tracking set by Argo. Ideally we'd like new namespaces to also
be tracked by Argo, but there's currently an issue with a failing
integration test.
Also wrap error message if setting the app instance errors on the
namespace.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* fix: always return true with `hasManagedMetadata`
If `hasManagedMetadata` is set, `true` should always be returned.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* docs: add clarifying docs on resource tracking
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* style: pr tweaks
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* fix: re-add label unsetting
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
* Update gitops-engine to current master
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
Signed-off-by: pashavictorovich <pavel@codefresh.io >
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
Co-authored-by: pashavictorovich <pavel@codefresh.io >
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
2022-11-04 08:59:16 -04:00
Leonardo Luz Almeida
327936d164
fix: handle apiGroup updates in resource-tracking ( #11012 )
...
* fix: handle apiGroup updates in resource-tracking
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Fix test
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* change the fix approach by inspecting tracking id from the config
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* add unit-test to validate the scenario
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* fix test lint
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* review fixes
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Reword godocs for clarity
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
2022-11-03 15:02:13 -04:00
Blake Pettersson
5f3fc68b17
feat: add permitOnlyProjectScopedClusters flag ( #10237 )
...
This commit adds a new flag, `permitOnlyProjectScopedClusters`, which
prevents any application from syncing to clusters which are not a part
of the same project. Fixes #10220 .
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com >
2022-09-08 07:33:10 -04:00
jannfis
068048cb80
feat: Applications in any namespace ( #9755 )
...
* feat: Applications in any namespace
Signed-off-by: jannfis <jann@mistrust.net >
* Fix typo in CI
Signed-off-by: jannfis <jann@mistrust.net >
* Create argocd-e2e-external namespace
Signed-off-by: jannfis <jann@mistrust.net >
* Update from codegen
Signed-off-by: jannfis <jann@mistrust.net >
* Remove debug code
Signed-off-by: jannfis <jann@mistrust.net >
* Update help text for -N option to app create
Signed-off-by: jannfis <jann@mistrust.net >
* Wrap error when retrieving AppProject from cache
Signed-off-by: jannfis <jann@mistrust.net >
* Check for controller namespace first before matching on additional ns
Signed-off-by: jannfis <jann@mistrust.net >
* Improve TestAppProjectIsSourceNamespacePermitted unit test
Signed-off-by: jannfis <jann@mistrust.net >
* Get rid of some debug leftovers
Signed-off-by: jannfis <jann@mistrust.net >
* Better error wrapping; return IsNotFound as-is
Signed-off-by: jannfis <jann@mistrust.net >
* Updates from codegen
Signed-off-by: jannfis <jann@mistrust.net >
* We don't need AppShortName() anymore
Signed-off-by: jannfis <jann@mistrust.net >
* Update end-to-end tests to use annotation methods
Signed-off-by: jannfis <jann@mistrust.net >
* Add e2e tests to test for app creation in not permitted ns
Signed-off-by: jannfis <jann@mistrust.net >
* Remove deprecated code
Signed-off-by: jannfis <jann@mistrust.net >
* Remove dead code
Signed-off-by: jannfis <jann@mistrust.net >
* Add RBACName() method to application type
Signed-off-by: jannfis <jann@mistrust.net >
* Update from codegen
Signed-off-by: jannfis <jann@mistrust.net >
* Fix e2e test
Signed-off-by: jannfis <jann@mistrust.net >
* Update codegen
Signed-off-by: jannfis <jann@mistrust.net >
* Move RBAC name generation to an application receiver
Signed-off-by: jannfis <jann@mistrust.net >
* Fix sync window status in UI
Signed-off-by: jannfis <jann@mistrust.net >
* Fix pod logs viewer
Signed-off-by: jannfis <jann@mistrust.net >
* Fix application events in UI
Signed-off-by: jannfis <jann@mistrust.net >
* Fix application search in UI
Signed-off-by: jannfis <jann@mistrust.net >
* Fix yarn lint
Signed-off-by: jannfis <jann@mistrust.net >
* Only set up cluster-wide application informer when additional namespaces are specified
Signed-off-by: jannfis <jann@mistrust.net >
* Adapt e2e test to a changed error message
Signed-off-by: jannfis <jann@mistrust.net >
* Application namespace should be taken into account for create
Signed-off-by: jannfis <jann@mistrust.net >
* Use non-qualified application name as Helm release name
Signed-off-by: jannfis <jann@mistrust.net >
* Support --app-namespace in e2e tests
Signed-off-by: jannfis <jann@mistrust.net >
* Enable more e2e tests
Signed-off-by: jannfis <jann@mistrust.net >
* Increase e2e timeout for newly added tests
Signed-off-by: jannfis <jann@mistrust.net >
2022-08-10 11:39:10 +02:00
jannfis
591c4d9d15
fix: Ignore non-self-referencing resources while pruning ( #10198 )
...
* fix: Ignore non-self-referencing resources while pruning
Signed-off-by: jannfis <jann@mistrust.net >
* Pull in latest gitops-engine code
Signed-off-by: jannfis <jann@mistrust.net >
* Revert a replace in go.mod
Signed-off-by: jannfis <jann@mistrust.net >
2022-08-08 19:37:45 +02:00
Leonardo Luz Almeida
22a3b02a2d
feat: Introduces Server-Side Apply as sync option ( #9711 )
...
* feat: Introduces Server-Side Apply as sync option
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* add docs
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Implement the structured-merge diff when ssa is enabled
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* update gitops-engine
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* update gitops-engine
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* go mod tidy
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Add server-side apply option to the UI
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* update gitops-engine to master
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* fix live default values
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
2022-08-05 19:16:35 -04:00
Michael Crenshaw
47e4133cc0
Merge pull request from GHSA-2m7h-86qq-fp4v
...
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev >
fix references
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev >
use long enough state param for oauth2
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev >
typo
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev >
more entropy
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev >
fix test
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev >
2022-06-21 09:39:01 -04:00
Leonardo Luz Almeida
eb3517baad
fix: Ignore diff with schema ( #9170 )
2022-05-31 13:21:22 -04:00
Leonardo Luz Almeida
1547b44ffc
feat: Allow configuring system wide ignore differences for all resources ( #8224 )
...
* feat: Allow configuring system wide ignore differences for all resources
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* Add example config to argocd-cm.yaml
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
2022-01-19 14:57:43 -08:00
Leonardo Luz Almeida
6240ef00e7
feat: new sync option to use ignore diff configs during sync ( #8078 )
...
feat: new sync option to use ignore diff configs during sync (#8078 )
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
2022-01-13 13:00:17 -08:00
Leonardo Luz Almeida
970bb80b28
feat: add new sync option to fail if finds shared resources ( #7444 )
...
* feat: add new sync option to fail if finds shared resources
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com >
* docs: add docs for FailOnSharedResource sync option
Signed-off-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com >
2021-10-20 08:06:41 -07:00
pasha-codefresh
ddc9f56d05
feat: Cluster name as part of sync ( #7394 )
...
feat: Cluster name as part of sync (#7394 )
Signed-off-by: pashavictorovich <pavel@codefresh.io >
2021-10-18 18:44:54 -07:00
pasha-codefresh
7b89c4e53c
feat: Project scoped repo ( #6943 )
...
feat: Project scoped repo (#6943 )
Signed-off-by: pashavictorovich <pavel@codefresh.io >
2021-08-16 09:38:37 -07:00
Alexander Matyushentsev
2541fa0332
refactor: upgrade gitops engine (argoproj/gitops-engine/#286) ( #6491 )
...
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
2021-06-17 12:06:18 -07:00
Alexander Matyushentsev
e23f3f495d
fix: avoid possible nip pointer dereference during syncing ( #6354 )
...
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
2021-05-28 07:25:35 -07:00
Alexander Matyushentsev
3604a588bb
refactor: upgrade k8s client to v0.21.0 ( #6322 )
...
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
2021-05-27 10:20:53 -07:00
Alexander Matyushentsev
9b32e01104
feat: cache resolved git/helm repository revisions ( #6102 )
...
* feat: cache resolved git/helm repository revisions
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
2021-05-19 12:30:15 -07:00
jannfis
ae49b45249
chore: Upgrade Go module to v2 ( #5931 )
...
* chore: Upgrade Go module to v2
Signed-off-by: jannfis <jann@mistrust.net >
* Restore import order
Signed-off-by: jannfis <jann@mistrust.net >
* fix knowntypes_normalizer codegen error
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
* fix codegen
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
* fix Procfile
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
2021-04-01 20:44:18 +02:00
Alexander Matyushentsev
439963f4c9
feat: Support kubectl replace instead of apply ( #2730 ) ( #5802 )
...
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
2021-03-17 22:02:43 -07:00
Alexander Matyushentsev
d957ab467e
feat: support resource prune propagation policy ( #5743 )
...
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com >
2021-03-12 09:01:36 -08:00
kshamajain99
baa0f2e39c
feat: selective sync ( #3877 ) ( #5347 )
...
* selective sync
Signed-off-by: kshamajain99 <kshamajain99@gmail.com >
2021-01-29 12:26:47 -08:00
May Zhang
f5b9704267
feat: prune last ( #5199 )
...
* feat: prune last
fixes : #5080 .
If sync option has PruneLast=true, or individual resource has annotation argocd.argoproj.io/sync-options: PruneLast=true, these prune tasks get assigned with a new sync wave.
the new sync wave is the last sync wave of non-prune tasks which is in sync phase + 1, so that these resources will be pruned after all sync phase resources are synced and healthy.
Signed-off-by: May Zhang <may_zhang@intuit.com >
* fix: go mod tidy
Signed-off-by: May Zhang <may_zhang@intuit.com >
2021-01-06 14:13:02 -08:00
Jesse Suen
2f72f3adad
fix: sync hooks using generateName was using fixed timestamp suffix ( #4787 )
...
Signed-off-by: Jesse Suen <Jesse_Suen@intuit.com >
2020-11-13 01:18:15 -08:00
Jesse Suen
dea75eb481
fix: inject artificial delay between sync waves to better support health assessments ( #4715 )
...
Signed-off-by: Jesse Suen <jesse_suen@intuit.com >
2020-11-02 12:17:43 -08:00
Alexander Matyushentsev
a96b476f16
refactor: upgrade gitops-engine version ( breaking API changes related to logr mirgation ) ( #4652 )
2020-10-27 14:10:24 -07:00
May Zhang
f512d213cf
feat: global project ( #4506 )
...
* feat: global project
* feat: revert back argocd-cm.yaml
* feat: remove commented code.
* feat: check err
* feat: corrected comments.
* feat: merge sync windows
* feat: getProject
* feat: fix lint error
* feat: update existing test case
* feat: minor comments
* feat: Fixed for sync window which is also called from API server.
* feat: fix application tests
* feat: block by sync window
* feat: test using sync window
* feat: updated based on code review
* feat: fixed comment
2020-10-13 15:12:05 -07:00
May Zhang
fbfa89d358
fix: Support transition from a git managed namespace to auto create ( #4401 )
...
* fix: Support transition from a git managed namespace to auto create
* fix: Support transition from a git managed namespace to auto create
2020-09-22 17:38:55 -07:00
May Zhang
067dcce88d
feat: auto create namespace ( #3976 )
...
* feat: auto create namespace
* feat: fixing yarn lint error.
* feat: fixing yarn lint error.
* update to the latest gitops-engine
* fix tidiness of go.sum
2020-07-27 13:33:08 -07:00
Alexander Matyushentsev
42e24e6e2a
fix: controller should not re-trigger auto-sync if sync failed due to comparison error ( #3824 )
2020-06-22 14:09:22 -07:00
Darshan Chaudhary
d63ced413e
feat: add time taken to complete deployment ( #3715 )
...
* feat: add time taken to complete deployment
Signed-off-by: darshanime <deathbullet@gmail.com >
* feat: add test for adding deploy started at time
Signed-off-by: darshanime <deathbullet@gmail.com >
* feat: use hourglass for time to deploy
Signed-off-by: darshanime <deathbullet@gmail.com >
* feat: add comments to RevisionHistory fields
Signed-off-by: darshanime <deathbullet@gmail.com >
2020-06-10 14:28:40 +02:00
