Commit Graph

9 Commits

Author SHA1 Message Date
Regina Voloshin
4835e5008a fix: Exec with disable auth not logged in #17114 (#19529)
* initial with tests

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* refactor

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* cleanup

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* made TerminalOpts public and lint

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* pass reference

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

---------

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
2024-08-15 10:48:45 +00:00
pasha-codefresh
e36248cb22 Merge commit from fork
* feat: verify rbac on each message and not just during handshake

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* cover with tests

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix: linter and e2e tests

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix: linter and e2e tests

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
2024-07-24 12:18:15 +03:00
Matthieu MOREL
33df2ce698 chore: enable goimports linter (#18564)
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-06-10 09:18:12 -04:00
jannfis
d69c61ae1a Merge pull request from GHSA-6v85-wr92-q4p7
* fix: Fix concurrency issue in session manager

Signed-off-by: jannfis <jann@mistrust.net>

* Add note that modification to the map must be done in a thread safe manner

* chore: fix linter issues

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: pashakostohrys <pavel@codefresh.io>
2024-03-18 03:59:06 -04:00
pasha-codefresh
e047efa8f9 Merge pull request from GHSA-c8xw-vjgf-94hr
Signed-off-by: pashakostohrys <pavel@codefresh.io>
2023-08-21 16:15:09 -04:00
Edmund Rhudy
f2105d937d fix: adds WebSocket ping to interactive terminal (#14191) (#14192)
This adds a WebSocket ping message on a 5-second interval, sent
from the server to the client. This ensures that the interactive
terminal will remain open and won't be closed by load balancers
that are reaping idle connections.

Signed-off-by: Edmund Rhudy <erhudy@users.noreply.github.com>
2023-07-07 10:59:08 -04:00
Michael Crenshaw
43b7ded16c fix: terminal websocket write lock to avoid races (#10011)
* fix: protect terminal WriteMessage with a lock

Signed-off-by: CI <michael@crenshaw.dev>

* give write its own lock

Signed-off-by: CI <michael@crenshaw.dev>
2022-07-15 17:23:28 -07:00
Michael Crenshaw
cbc7966441 fix: 'unexpected reserved bits' breaking web terminal (#9605) (#9895)
* fix: 'unexpected reserved bits' breaking web terminal (#9605)

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* make things more like they were originally, since the mutex fixes the problem

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* fix typo, don't pass around a pointer when it isn't necessary

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* apply suggestions

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
2022-07-07 19:39:34 +00:00
Ben Ye
67cbe12f0b feat: support pod exec terminal via websockets (#8905)
feat: support pod exec terminal via websockets (#8905)

Signed-off-by: Ben Ye <ben.ye@bytedance.com>
2022-04-19 18:36:05 +00:00