marcel/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd.git synced 2026-03-29 12:58:48 +02:00
Code Issues Packages Projects Releases Wiki Activity
7,448 Commits 799 Branches 559 Tags
21026dba43d2ca1c07917614ce7c94de55b11b32
Commit Graph

68 Commits

Author SHA1 Message Date
Matthieu MOREL
1c6ec19a86 fix: use ErrorContains(t, err instead of Contains(t, err.Error() (#20220) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-10-04 09:36:05 -04:00
Alexander Matyushentsev
0acecad8f8 feat: reduce redis traffic caused by app resource tree updates in redis (#19722) 
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2024-08-29 17:16:48 +00:00
Pavel
0894ddc89e fix(#19306): close redis cache gzip writer (#19307) 
* close redis cache writer

flush is not enough, we need to close the writer too

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* test compressed redis value

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
 2024-07-31 08:57:46 +05:30
Matthieu MOREL
3dcddee199 chore: enable float-compare rule from testifylint (#18721) 
* chore: enable float-compare rule from testifylint

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update managed_fields_test.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update managed_fields_test.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-21 14:16:32 -04:00
Matthieu MOREL
eac08dcf79 chore: extend require-error rule from testifylint (#18681) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-15 13:51:18 -04:00
Matthieu MOREL
9f1e2e8453 chore: enable gocritic linter (#18633) 
* chore: enable gocritic linter

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update settings.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update app.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update grpcproxy.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update grpcproxy.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update util.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update server.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update app_management_ns_test.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update app_management_test.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update path_traversal.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update sessionmanager.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-13 15:10:00 -04:00
Matthieu MOREL
3160369469 chore: enable compare and nil-compare rules from testifylint linter (#18581) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-11 16:38:35 +00:00
Matthieu MOREL
7cf5ed06d4 chore: enable gofumpt and whitespace linters (#18567) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-11 15:41:55 +00:00
Matthieu MOREL
d7e99224d4 chore: enable errorlint linter on util folder (#18588) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-11 10:42:32 -04:00
Matthieu MOREL
4a01f8a69a chore: enable expected-actual rule from testifylint linter (#18575) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-10 20:33:00 +00:00
Matthieu MOREL
32519c70a5 chore: enable error-nil rule from testifylint linter (#18544) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-10 10:38:55 -04:00
Matthieu MOREL
33df2ce698 chore: enable goimports linter (#18564) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-10 09:18:12 -04:00
Matthieu MOREL
71e1f30741 fix: enable bool-compare rule from testifylint linter (#18414) 2024-06-05 18:13:45 -04:00
Matthieu MOREL
9fe1dbfcad fix: enable misspell linter (#18412) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-05-28 12:51:04 +03:00
Alexy Mantha
4e46a5e8fa feat(controller): use manifest generate path during comparison (#14242) (#15636) 
* squash commits

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* Update util/git/client.go

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* fix error message

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* add git client options

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* Update generated code

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* run fmt

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* fix tests

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* failed gen

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* tweak logs and rename cache

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* validate revisions

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* fix tests

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* fix tests

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* fmt

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* fix linting

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* fixes from review

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* generate

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* fix

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* use log context

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

---------

Signed-off-by: Alexy Mantha <alexy@mantha.dev>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2024-04-04 16:01:11 -04:00
Nathan Romriell
c4fdc54195 fix(repo-server): excess git requests, add shared cache lock on revisions (Issue #14725) (#17109) 
* fix(repo-server): excess git requests, cache lock on revisions

Signed-off-by: nromriell <nateromriell@gmail.com>

* fix: pr feedback, simplify, add configurable variable

Signed-off-by: nromriell <nateromriell@gmail.com>

* fix: codegen, lint

Signed-off-by: nromriell <nateromriell@gmail.com>

* fix: test print, no opts set, var type nit

Signed-off-by: nromriell <nateromriell@gmail.com>

* chore: add additional logging for unexpected cache error

Signed-off-by: nromriell <nateromriell@gmail.com>

---------

Signed-off-by: nromriell <nateromriell@gmail.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
 2024-03-25 11:26:14 -04:00
shlomi tubul
adceae9ec8 feat: Add support for passing Redis Sentinel username(ACL) and password (#17168) 
* Add support for passing Sentinel username and password

Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>

* fix align with var naming

Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>

* fix align with var naming

Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>

---------

Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>
Co-authored-by: ShlomiTubul <shlomi.tubul@placer.ai>
 2024-02-11 00:48:15 -05:00
Yudi A Phanama
be1f0eafb8 fix(redis): go-redis v9 regression missing metrics and reconnect hook (#13415) (#15275) 
* fix(redis): go-redis v9 regression missing metrics and reconnect hook

Signed-off-by: phanama <yudiandreanp@gmail.com>

* fix: golangci lint return values not checked in tests

Signed-off-by: phanama <yudiandreanp@gmail.com>

* chore: move dnsError var locally into func

Signed-off-by: phanama <yudiandreanp@gmail.com>

---------

Signed-off-by: phanama <yudiandreanp@gmail.com>
 2024-01-29 10:31:15 -05:00
Alexander Matyushentsev
c5b9c67073 fix: support specifying username/password for redis holding manifests in argocd-server (#16786) 
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2024-01-09 00:04:46 +00:00
Alexander Matyushentsev
4afddf71cc feat: webhook should use 'rename' to copy app manifests of previous commit (#16754) 
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2024-01-05 08:53:52 -08:00
Nathan Romriell
5c187a1955 fix(repo-server): excess git requests, resolveReferencedSources and runManifestGenAsync not using cache (Issue #14725) (#16410) 
* fix(repo-server): excess git requests part 1, resolveReferencedSources and runManifestGenAsync

Signed-off-by: nromriell <nateromriell@gmail.com>

* fix: remove unnecessary settings instantiation

Signed-off-by: nromriell <nateromriell@gmail.com>

---------

Signed-off-by: nromriell <nateromriell@gmail.com>
 2023-11-30 10:03:34 -05:00
Yudi A Phanama
23f2767250 fix(cli): pass redis compression to cluster stats and shards commands (#16060) (#16421) 2023-11-29 17:56:40 +05:30
Nathanael Liechti
819f0b3e87 feat(oidc): optionally query OIDC UserInfo to gather group claims (#12062) 
Signed-off-by: Nathanael Liechti <technat@technat.ch>
 2023-11-21 10:16:50 -05:00
Michael Crenshaw
460ecf3ac2 feat: enable gzip compression in Redis by default (#13458) (#13459) 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2023-05-04 17:56:47 -04:00
Nolan Emirot
7b74e1993e chore: update redis client to v9 (#12746) 
* chore: update redis

Signed-off-by: emirot <emirot.nolan@gmail.com>

* chore: update redis

Signed-off-by: emirot <emirot.nolan@gmail.com>

* chore: update redis

Signed-off-by: emirot <emirot.nolan@gmail.com>

---------

Signed-off-by: emirot <emirot.nolan@gmail.com>
 2023-03-08 09:42:10 -05:00
Nick Miyake
ba86be2fcb fix: fix typo in local variable name (#11624) 
Signed-off-by: Nick Miyake <nmiyake@palantir.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2023-02-20 01:12:01 +00:00
Mitsuo Heijo
f0975b9ad3 chore: remove incompatible miniredis dependency (#10566) 
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>

Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
 2022-09-15 08:10:29 -04:00
Alexander Matyushentsev
9b4f468f72 feat: support gzip compression for data stored in redis (#10190) 
* feat: support gzip compression for data stored in redis

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* allow using different redis compression algorithms

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2022-08-15 16:15:27 -04:00
Soumya Ghosh Dastidar
3ea72eb489 feat: add support for redis acl username/password flow (#8676) 
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
 2022-03-04 10:29:19 -08:00
pasha-codefresh
91fea1470f feat: add test to redis_hook.go (#7233) 
* add test to redis_hook.go

Signed-off-by: pashavictorovich <pavel@codefresh.io>

* restart action

Signed-off-by: pashavictorovich <pavel@codefresh.io>
 2021-09-16 08:06:29 -07:00
pasha-codefresh
6f794d0dc9 fix: Redis should reconnect on connectivity issue (#7207) 
fix: Redis should reconnect on connectivity issue (#7207)

Signed-off-by: pashavictorovich <pavel@codefresh.io>
 2021-09-15 09:05:48 -07:00
Noam Gal
f7614e0c4e fixed max to use MaxInt64 value (#6911) 
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
 2021-08-04 11:07:54 -07:00
Eldar Yusupov
2497679dcb feat: Add Redis SSL support. Fixes #4688 (#6742) 
* feat: Add Redis SSL support

Signed-off-by: Eldar Yusupov <eyusupov@gmail.com>
 2021-07-21 10:07:24 -07:00
Ishita Sequeira
f533ed17f0 feat: simplify parametrization of Argo CD server processes (#6328) 
feat: simplify parametrization of Argo CD server processes  (#6328)

Signed-off-by: Ishita Sequeira <isequeir@redhat.com>
 2021-06-10 13:03:47 -07:00
Shoubhik Bose
6aee524e0a chore: compile-time validation of adherence to interface contract (#5850) 
* fix: compile time validation of interface contract

Signed-off-by: Shoubhik Bose <shbose@redhat.com>

* fix: application specific parameter override is not reflected in application parameters tab (#5845)

Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: Shoubhik Bose <shbose@redhat.com>

* chore: compile time resolution

Signed-off-by: Shoubhik Bose <shbose@redhat.com>

* chore: adherance to contract

Signed-off-by: Shoubhik Bose <shbose@redhat.com>

* Revert "fix: application specific parameter override is not reflected in application parameters tab (#5845)"

This reverts commit 43c8012062.

Signed-off-by: Shoubhik Bose <shbose@redhat.com>

Co-authored-by: May Zhang <may_zhang@intuit.com>
 2021-04-15 12:45:57 -07:00
jannfis
ae49b45249 chore: Upgrade Go module to v2 (#5931) 
* chore: Upgrade Go module to v2

Signed-off-by: jannfis <jann@mistrust.net>

* Restore import order

Signed-off-by: jannfis <jann@mistrust.net>

* fix knowntypes_normalizer codegen error

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix codegen

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* fix Procfile

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2021-04-01 20:44:18 +02:00
Alexander Matyushentsev
21670820a4 refactor: optimize argocd-application-controller redis usage (#5345) 
* refactor: controller uses two level caching to reduce number of redis calls

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2021-01-29 11:42:40 -08:00
Alexander Matyushentsev
4417cc8180 fix: use json serialization to store cache instead of github.com/vmihailenco/msgpack (#4965) 
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2020-12-03 10:24:47 -08:00
Jonathan West
2166fea351 fix: Repo-server has silent unmarshalling errors leading to empty applications (#4423) (#4708) 
* fix: Repo-server has silent unmarshalling errors leading to empty applications (#4423)
 2020-11-02 14:15:31 -08:00
Alexander Matyushentsev
a96b476f16 refactor: upgrade gitops-engine version ( breaking API changes related to logr mirgation ) (#4652) 2020-10-27 14:10:24 -07:00
Alexander Matyushentsev
303925f4a0 feat: Support controller horizontal scaling (#4285) 2020-10-09 13:16:54 -07:00
Alexander Matyushentsev
d60486fb47 fix: use redis pub-sub with correct context (#4300) 2020-09-10 09:57:32 -07:00
dherman
b3be910465 perf: upgrade redis deps to enable compression (#4259) 
Newer versions of the redis go libraries include built-in support for
compression of values going to and from redis.  Since the controller
is extremely chatty and makes heavy use of redis for caching, this
reduces the amount of bandwidth requires significantly.

This change should be backwards compatible since the redis libraries
detect whether or not compression was used and does not error in the
no compression case.

Fixes #4256
 2020-09-04 13:59:59 -07:00
Alexander Matyushentsev
fca0f69b5e refactor: Replace status.observedAt with redis pub/sub channels for resource tree updates (#1340) (#4208) 2020-08-31 10:18:12 -07:00
Alexander Matyushentsev
5d5d6a4ad6 feat: Display cluster info on cluster details page (#3793) 
* feat: Display cluster info on cluster details page

* Store cluster info in cache instead of secret
 2020-06-22 17:51:20 -07:00
Josh Soref
a724574ede chore: Spelling (#3647) 
chore: Spelling (#3647)
 2020-05-27 10:22:13 -07:00
Alexander Matyushentsev
cd1de6e680 fix: redis request failed with nil error should not be counted as failed (#3576) 2020-05-12 18:02:22 -07:00
Alexander Matyushentsev
24fa758444 fix: enable redis retries; add redis request duration metric (#3575) 2020-05-12 14:39:18 -07:00
Alexander Matyushentsev
f5b600d4af feat: limit the maximum number of concurrent login attempts (#3467) 
* feat: limit the maximum number of concurrent login attempts

* unit test rate limiter

* address reviewer questions
 2020-04-23 12:33:17 -07:00
jannfis
76bacfdea4 fix: Add initial implementation for rate limiting failed logins (#3404) 
* fix: Add initial implementation  for rate limiting failed logins

* Trigger test build

* Remove deprecated code and fix new project tests

* move cache related code from sessionmanager to cache access wrapper

* avoid using sleep in sessionmanager tests

* mention SECONDS in session manager environment variables to make it easier to understand meaning of each variable

* Login button should be disabled while user is waiting for login result

* prevent timing-based user enumeration attack

* reject too many failed attempts; always compute hash and introduce random delay

* remove unused constants

* fix linter errors

Co-authored-by: Alexander Matyushentsev <amatyushentsev@gmail.com>
 2020-04-21 11:10:25 -07:00