marcel/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd.git synced 2026-04-03 15:28:48 +02:00
Code Issues Packages Projects Releases Wiki Activity
7,448 Commits 807 Branches 559 Tags
21026dba43d2ca1c07917614ce7c94de55b11b32
Commit Graph

154 Commits

Author SHA1 Message Date
변재한
0aa6c49465 feat: add support for helm skipTests flag (#20118) 
Signed-off-by: jaehanbyun <awbrg789@naver.com>
 2024-10-05 19:55:46 -04:00
KangManJoo
3070297d6b fix(helm): escape consecutive commas in cleanSetParameters (#19269) (#20113) 
Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
Signed-off-by: daengdaengLee <gunho1020@gmail.com>
Co-authored-by: daengdaengLee <gunho1020@gmail.com>
 2024-10-02 15:04:22 -04:00
Tony Au-Yeung
fa54ce221e fix: oras-go client should fallback to docker config if no credentials specified (#18133) 
* oras-go client should fallback to docker config if no credentials specified

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix tests

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix lint

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* gofumpt

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Validate auth header

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

---------

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
 2024-09-27 21:33:42 +05:30
ilia-medvedev-codefresh
20f9719001 fix: cleanup tempdir when errors occur in Helm chart extraction (#19861) 
Fixed merge conflicts. 

Signed-off-by: Ilia Medvedev <ilia.medvedev@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: Dan Garfield <dan@codefresh.io>
 2024-09-17 15:15:32 +05:30
KangManJoo
b098f2152e chore: improve error logs (#10592) (#19743) 
Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
 2024-09-11 13:14:47 -04:00
Nathanael Liechti
bacdceda79 feat: allow no_proxy to be specified on repoCreds (#18526) 
Signed-off-by: Nathanael Liechti <technat@technat.ch>
 2024-08-20 12:54:39 -04:00
Michael Crenshaw
1dd2821631 feat: collect and log hydration commands (#19346) 
* feat: collect and log hydration commands

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix tests

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* don't actually log for now

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* add helm test, handle random values file path

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix test

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* simplify; only return commands on success; only return helm template command, not helm dependency

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* kustomize test

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* only return commands on success, to match Helm

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix import order

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* simplify, since we're not collecting non-template Helm commands

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* lint

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fixes from comments

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2024-08-09 16:06:58 +00:00
Michael Crenshaw
5ccea0d4ab chore: remove dead Helm version code (#19449) 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2024-08-09 08:37:18 -04:00
Ishita Sequeira
19e3c1ae49 fix: pass refSources when calling GetAppDetails (#18962) 
* Get refSources when calling GetAppDetails

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix lint errors

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix unit tests

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix unit tests

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

---------

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
 2024-07-09 10:42:54 -04:00
Cayde6
06b0f957b8 chore(migrate): migrate mockery codegen to use packages(#18579) (#18617) 
* chore(migrate): mockery migrate to packages

migrate interface
- remove go:generate
- generate mock

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* chore(migrate: mockery migrate to package

add mockgen stage
- add mockgen command to Makefile
- add generate-mock.sh
- add install mockery to install-codegen-go-tool.sh

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

---------

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
 2024-07-02 10:48:38 -04:00
Matthieu MOREL
0d1d1a1b18 chore: extend require-error rule from testifylint (#18675) 
* chore: extend require-error rule from testifylint

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update helm_test.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-14 17:40:33 -04:00
Matthieu MOREL
7cf5ed06d4 chore: enable gofumpt and whitespace linters (#18567) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-11 15:41:55 +00:00
Matthieu MOREL
d7e99224d4 chore: enable errorlint linter on util folder (#18588) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-11 10:42:32 -04:00
Matthieu MOREL
4a01f8a69a chore: enable expected-actual rule from testifylint linter (#18575) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-10 20:33:00 +00:00
Matthieu MOREL
32519c70a5 chore: enable error-nil rule from testifylint linter (#18544) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-10 10:38:55 -04:00
Blake Pettersson
4fd478b271 feat: project-scoped repository credential improvements (#18388) 
* feat: project-scoped repo cred improvements

Implementation of #18290

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: missed a test

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* wip project key changes

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: update mocks

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: fix tests

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: equivalence even if project is empty

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: wip delete

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* refactor: remove repositorydb

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* chore: improve logging

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: pass project to getrepository

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: fix failing test

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: compare with project secret instead of app secret

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: get repository needs same logic as delete

Need to update the spec accordingly.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* feat: add project flag to repo rm command

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* docs: make codegen

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: fix failing test

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: more failing tests

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* chore: minor cleanups

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* chore: propagate project from ui

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: add new test cases

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* chore: code review, improve formulation

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* refactor: address cr feedback

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2024-06-07 18:47:55 -07:00
Matthieu MOREL
44b8dc1a4c chore: enable len and empty rules from testifylint linter (#18516) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-06-07 15:12:50 -04:00
Blake Pettersson
049900e646 chore: automate mock generation v2 (#18371) 
* Add go:generate statements for mockery

Signed-off-by: Will Roden <will@roden.cc>

* revert whitespace change

Signed-off-by: Will Roden <will@roden.cc>

* go generate everything

Signed-off-by: Will Roden <will@roden.cc>

* make gogen

Signed-off-by: Will Roden <will@roden.cc>

* chore: upgrade to mockery v2.40.2

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Will Roden <will@roden.cc>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Will Roden <will@roden.cc>
 2024-05-23 11:15:15 +03:00
pasha-codefresh
48b636e32b chore: native client mock should be generated with go gen (#17864) 
* fix: native client mock should be generated with go gen

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix: native client mock should be generated with go gen

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* fix: native client mock should be generated with go gen

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* adopt repository_test.go to new helm mock client

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
 2024-04-16 17:33:47 -04:00
pasha-codefresh
ae29279cbe Merge pull request from GHSA-jhwx-mhww-rgc3 
* sec: limit helm index max size

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* sec: limit helm index max size

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* feat: fix tests and linter

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
 2024-03-28 14:38:03 +02:00
Pablo Aguilar
57d6e6557b fix: registry argument to be only the host instead full URL (#17381) 
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
 2024-03-12 10:21:53 -04:00
Andrew Block
c691d366a5 Corrected certificate managment for OCI helm charts (#16656) 
Signed-off-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
 2024-01-30 21:45:11 -05:00
Kota Kimura
da57e03cce fix: helm set parameter to allow passing list parameters (#15978) 
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
 2023-10-16 16:46:06 -04:00
pasha-codefresh
b8f92c4ff2 Merge pull request from GHSA-g687-f2gx-6wm8 
* feat: use untar with limiter

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* feat: use untar with limiter

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
 2023-09-07 10:12:15 -04:00
xashr
d836ec393d fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537) 
* fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registry

Signed-off-by: xashr <saschasynaos@gmail.com>

* Add test coverage for SemVer tags in TestGetTagsFromUrl

Signed-off-by: xashr <saschasynaos@gmail.com>

---------

Signed-off-by: xashr <saschasynaos@gmail.com>
 2023-08-04 16:16:58 -04:00
Michael Crenshaw
e2ab450642 chore: make helm template errors less verbose (#14772) 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2023-07-31 16:43:40 -04:00
Calchan
4a50a31caf chore: add gofmt to golangci-lint in Makefile and .github/workflows/ci-build.yaml (#13729) 
* fix: add gofmt to golangci-lint in Makefile and .github/workflows/ci-build.yaml

Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>

* fix go formatting issues using gofmt

Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>

* chore: simplify go code using gofmt

Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>

---------

Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>
 2023-07-05 16:16:25 -04:00
Michael Crenshaw
cec07ee1ce fix(cmp): discover plugins relative to app path (#13940) (#13946) 
* fix(cmp): discover plugins relative to app path (#13940)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* securejoin

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* intuitive constant names

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* comments

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* add missing import

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2023-06-15 21:17:04 +00:00
dromie
8c0456be18 fix: creds.CAPath passed helm in PullOCI (#13726) (#13871) 
Signed-off-by: Nandor Galambosi <dromie@gmail.com>
 2023-06-04 15:30:16 -07:00
Brett Lentz
488583fedd test: add tests to validate helm ranges (#4047) (#13662) 
Signed-off-by: Brett Lentz <brett.lentz@analog.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2023-05-28 00:46:16 +00:00
Marie Katrine Ekeberg
5d80789a26 fix: Disable keep alives for helm https connections (#13695) 
Signed-off-by: Marie Katrine Ekeberg <marie.ekeberg@tietoevry.com>
 2023-05-27 12:25:59 -04:00
pasha-codefresh
f356a54f19 feat: Support insecure flag for OCI pull command and upgrade helm version to 3.12.0 (#13608) 2023-05-18 20:02:20 -04:00
Alex Eftimie
a08282bf6b feat: use oras-go library to enable more complex OCI Helm authentication (#12554) 
* feat: use oras-go library to enable more complex OCI Helm authentication

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Update util/helm/client.go

Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Ran make mod-vendor-local

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

---------

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
 2023-05-11 09:24:23 -04:00
Eng Zer Jun
e8331b4d12 chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml (#13292) 
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2023-05-04 18:06:56 -04:00
Alexander Matyushentsev
2126bcf280 feat: support 'helm.sh/resource-policy: keep' helm annotation (#13157) 
* feat: support 'helm.sh/resource-policy: keep' helm annotation

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* document  annotation

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

---------

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
 2023-04-24 13:41:21 -07:00
Alex Eftimie
d9b8e0f37d feat: Expose Helm Chart metadata in Argo CD UI (#11352) (#11575) 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Co-authored-by: Remington Breeze <remington@breeze.software>
 2023-04-18 10:04:21 -07:00
my-git9
c9a47e95c4 chore: remove deprecated apiversion for deployment (#11830) 
Signed-off-by: xin.li <xin.li@daocloud.io>
 2023-03-29 20:24:05 +00:00
Andrii Chubatiuk
f16b722620 feat(kustomize): support envsubst in commonAnnotations and commonLabels (#11345) 
* support envsubst in kustomize commonAnnotations and commonLabels

Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@motional.com>

* added description for new parameter

Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@motional.com>

---------

Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@motional.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Andrii Chubatiuk <andrew.chubatiuk@motional.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2023-03-22 19:54:30 +00:00
Fish-pro
c85902c999 chore: use http constants instead of string (#12334) 
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
 2023-02-17 14:04:10 -05:00
Ishita Sequeira
c6fa942e94 feat: Multiple sources for applications (#2789) (#10432) 
* feat: support multiple sources for application

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

remove debug logging and unwanted code

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

fix lint and unit test errors

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

fix lint and unit test errors

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix bug introduced after rebase

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

executed make codegen

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* rebase with master

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

remove unwanted logging

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

fix ci failures

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix index out of bounds error

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* ui fixes

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* add revisions to SyncOperation for rollback

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* change Source to *ApplicationSource in ApplicationSpec

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix env variable read logic for ValueFiles

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* update multiple sources doc

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* add repository lock and checkout target revision

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

fix codegen

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* checkout all sources before generating manifest

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

generate mock reposerverclient

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* update logic for returning ManifestResponse to avoid nil pointer issues

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix nil reference and key mismatch bugs; add more logs (#6)

* fix nil reference and key mismatch bugs; add more logs
* remove temporary comment
* addressed the lint failure and added chart to RefTargeRevisionMapping
* normalize git repo (#7)
* do not leak lock releases
* prevent deadlock
* allow spec update
* move settings fetch outside loop
* cache busing
* return err instead of logging it
* no caching in test
* fix cache key marshaling

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Rebase with master

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* update grpc field numbers

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* path resolution tests (#12)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

do things in better ways

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

consolidate

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* add regex check for value of source.ref

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* add webhook tests

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

change Source to *ApplicationSource in ApplicationSpec

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

address PR comments

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

rebase with master

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

Retrigger CI pipeline

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

rebased with master

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix env variable read logic for ValueFiles

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

Address PR comments

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* add repository lock and checkout target revision

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

fix codegen

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* checkout all sources before generating manifest

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* generate mock reposerverclient

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* address comments

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* update logic for returning ManifestResponse to avoid nil pointer issues

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix nil reference and key mismatch bugs; add more logs (#6)

* fix nil reference and key mismatch bugs; add more logs
* remove temporary comment
* addressed the lint failure and added chart to RefTargeRevisionMapping
* normalize git repo (#7)
* do not leak lock releases
* prevent deadlock
* allow spec update
* move settings fetch outside loop
* cache busing
* return err instead of logging it
* no caching in test
* fix cache key marshaling

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Rebase with master

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* update grpc field numbers

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* add regex check for value of source.ref

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* Rebase with master

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* Added unit tests (#15)

* add unit tests 1
* fix lint

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix application parameters tab, rebased UI changes, tests

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* More tests (#16)

* more tests

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

fix lint error

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

Test get ref sources (#17)

* test GetRefSources

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix lint

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: ishitasequeira <ishiseq29@gmail.com>

GenerateManifests test (#18)

* GenerateManifests test

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Fix broken tests (#19)

* fix broken tests

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Symlink test (#20)

* check referenced sources for out-of-bounds symlinks

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* unlock the values file repo before doing a symlink check (#22)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* multi source docs (#21)

* multi source docs

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix warning title

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* clarify

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* clarify

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* add e2e tests for multiple sources and fix UI lint (#23)

* add e2e tests for multiple sources and fix UI lint

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* add auto-sync and hard refresh to e2e tests

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* change refresh type to RefreshTypeNormal for e2e

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* update e2e testcase with helm data

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* add TestMultiSourceAppWithSourceOverride

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* add missing yaml file

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* rebase with master

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* rebase with master

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

* fix lint

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2022-12-16 15:47:08 -05:00
Detlev V
a89e489316 fix: support relative links in OCI tags query response (#11708) 
* fix: support relative links in OCI tags query response

Pagination for OCI tags retrieval is not supported when the
Link header URI is relative.
According to https://docs.docker.com/registry/spec/api/#pagination
and the therein referenced RFC
https://www.rfc-editor.org/rfc/rfc5988#section-5
relative links should be resolved to the initial request URL

Signed-off-by: detvdl <detvdael.services@protonmail.com>

* chore: clean up unused prints & assert errors

Signed-off-by: detvdl <detvdael.services@protonmail.com>

* fix: stop double-escaping repoURL

Signed-off-by: detvdl <detvdael.services@protonmail.com>

* chore: CodeQL CWE-117 log sanitizing

Signed-off-by: detvdl <detvdael.services@protonmail.com>

* chore: remove unnecessary error

Signed-off-by: detvdl <detvdael.services@protonmail.com>

Signed-off-by: detvdl <detvdael.services@protonmail.com>
 2022-12-16 16:01:34 +00:00
Alex Eftimie
6ecd70ae74 fix(helm): helm v3 doesn't have these flags (#11100) (#11540) 
* fix: helm v3 doesn't have these flags

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Revert repoAdd change. Was to greedy, ca-file is needed there

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
 2022-12-07 12:41:43 -05:00
Alex Eftimie
9b6992af61 feat: Add wildcard support in OCI Helm Repositories targetRevision (#6686) (#10641) 
* Add wildcard support in OCI Helm Repositories

A naive approach, adapting existing code for fetching the index.

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Fix unittest missing mock

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Fix release resolution also in Manual Sync dialog

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Show target revision in application list. Tiles and Table updated

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Follow Link rel=next in tags response for tag list completion (signed)

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Wrap errors into fmt.Errorf according to PR review

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Address PR comments, add test for tags MaxVersion and pagination

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Apply suggestions from code review

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* more feedback from pr

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Revert url.JoinPath change - only available in 1.19

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* use strings.Join. add unittest

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Safe access to app.status.sync object

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Remove status.revision from UI. It doesn't bring much value and it does clutter the ui a bit

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Update util/helm/client.go

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* Update util/helm/client.go

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2022-11-25 21:51:30 +00:00
Alex Eftimie
2173b87b99 fix: set HELM_CONFIG_HOME dir for oci registry authentication; fixes: #11284 (#11285) 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
 2022-11-17 14:23:16 -08:00
Shuai Zhang
4328bfc1ff fix: allow resolving repo root as jsonnet lib path (#11119) 
Signed-off-by: shuai-zh <shuaiz8023@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
 2022-11-15 12:56:48 -08:00
my-git9
234fc9d1cd chore: beta.kubernetes.io/arch has been deprecated in 1.14 (#11016) 
Signed-off-by: xin.li <xin.li@daocloud.io>

Signed-off-by: xin.li <xin.li@daocloud.io>
 2022-11-07 07:54:44 -05:00
my-git9
662caa2030 chore: Add security logging in util/git|helm (#10410) 
Signed-off-by: xin.li <xin.li@daocloud.io>

Signed-off-by: xin.li <xin.li@daocloud.io>
Co-authored-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
 2022-08-23 18:08:55 +00:00
my-git9
9d21bb91b1 fix: Add logic to handle for file.Close() (#9963) (#10159) 
Signed-off-by: xin.li <xin.li@daocloud.io>
 2022-08-03 14:33:40 -04:00
jannfis
f34687bd80 chore: Replace deprecated ioutil in util packages (#9848) 
Signed-off-by: jannfis <jann@mistrust.net>
 2022-07-06 12:45:04 -04:00
Michael Crenshaw
f9c3319749 Merge pull request from GHSA-jhqp-vf4w-rpwq 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

defer instead of multiple close calls

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

oops

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

don't count jsonnet against max

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

fix codegen

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

add caveat about 300x ratio

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

fix versions

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

fix tests/lint

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
 2022-06-21 09:40:36 -04:00