mirror of
https://github.com/argoproj/argo-cd.git
synced 2026-04-04 15:58:49 +02:00
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
441 lines
16 KiB
Go
441 lines
16 KiB
Go
package webhook
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"html"
|
|
"net/http"
|
|
"net/url"
|
|
"path/filepath"
|
|
"regexp"
|
|
"strings"
|
|
|
|
gogsclient "github.com/gogits/go-gogs-client"
|
|
log "github.com/sirupsen/logrus"
|
|
"gopkg.in/go-playground/webhooks.v5/bitbucket"
|
|
bitbucketserver "gopkg.in/go-playground/webhooks.v5/bitbucket-server"
|
|
"gopkg.in/go-playground/webhooks.v5/github"
|
|
"gopkg.in/go-playground/webhooks.v5/gitlab"
|
|
"gopkg.in/go-playground/webhooks.v5/gogs"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
|
|
"github.com/argoproj/argo-cd/v2/common"
|
|
"github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
|
|
appclientset "github.com/argoproj/argo-cd/v2/pkg/client/clientset/versioned"
|
|
"github.com/argoproj/argo-cd/v2/reposerver/cache"
|
|
servercache "github.com/argoproj/argo-cd/v2/server/cache"
|
|
"github.com/argoproj/argo-cd/v2/util/argo"
|
|
"github.com/argoproj/argo-cd/v2/util/db"
|
|
"github.com/argoproj/argo-cd/v2/util/security"
|
|
"github.com/argoproj/argo-cd/v2/util/settings"
|
|
)
|
|
|
|
type settingsSource interface {
|
|
GetAppInstanceLabelKey() (string, error)
|
|
GetTrackingMethod() (string, error)
|
|
}
|
|
|
|
var _ settingsSource = &settings.SettingsManager{}
|
|
|
|
type ArgoCDWebhookHandler struct {
|
|
repoCache *cache.Cache
|
|
serverCache *servercache.Cache
|
|
db db.ArgoDB
|
|
ns string
|
|
appClientset appclientset.Interface
|
|
github *github.Webhook
|
|
gitlab *gitlab.Webhook
|
|
bitbucket *bitbucket.Webhook
|
|
bitbucketserver *bitbucketserver.Webhook
|
|
gogs *gogs.Webhook
|
|
settingsSrc settingsSource
|
|
}
|
|
|
|
func NewHandler(namespace string, appClientset appclientset.Interface, set *settings.ArgoCDSettings, settingsSrc settingsSource, repoCache *cache.Cache, serverCache *servercache.Cache, argoDB db.ArgoDB) *ArgoCDWebhookHandler {
|
|
githubWebhook, err := github.New(github.Options.Secret(set.WebhookGitHubSecret))
|
|
if err != nil {
|
|
log.Warnf("Unable to init the GitHub webhook")
|
|
}
|
|
gitlabWebhook, err := gitlab.New(gitlab.Options.Secret(set.WebhookGitLabSecret))
|
|
if err != nil {
|
|
log.Warnf("Unable to init the GitLab webhook")
|
|
}
|
|
bitbucketWebhook, err := bitbucket.New(bitbucket.Options.UUID(set.WebhookBitbucketUUID))
|
|
if err != nil {
|
|
log.Warnf("Unable to init the Bitbucket webhook")
|
|
}
|
|
bitbucketserverWebhook, err := bitbucketserver.New(bitbucketserver.Options.Secret(set.WebhookBitbucketServerSecret))
|
|
if err != nil {
|
|
log.Warnf("Unable to init the Bitbucket Server webhook")
|
|
}
|
|
gogsWebhook, err := gogs.New(gogs.Options.Secret(set.WebhookGogsSecret))
|
|
if err != nil {
|
|
log.Warnf("Unable to init the Gogs webhook")
|
|
}
|
|
|
|
acdWebhook := ArgoCDWebhookHandler{
|
|
ns: namespace,
|
|
appClientset: appClientset,
|
|
github: githubWebhook,
|
|
gitlab: gitlabWebhook,
|
|
bitbucket: bitbucketWebhook,
|
|
bitbucketserver: bitbucketserverWebhook,
|
|
gogs: gogsWebhook,
|
|
settingsSrc: settingsSrc,
|
|
repoCache: repoCache,
|
|
serverCache: serverCache,
|
|
db: argoDB,
|
|
}
|
|
|
|
return &acdWebhook
|
|
}
|
|
|
|
func parseRevision(ref string) string {
|
|
refParts := strings.SplitN(ref, "/", 3)
|
|
return refParts[len(refParts)-1]
|
|
}
|
|
|
|
// affectedRevisionInfo examines a payload from a webhook event, and extracts the repo web URL,
|
|
// the revision, and whether or not this affected origin/HEAD (the default branch of the repository)
|
|
func affectedRevisionInfo(payloadIf interface{}) (webURLs []string, revision string, change changeInfo, touchedHead bool, changedFiles []string) {
|
|
switch payload := payloadIf.(type) {
|
|
case github.PushPayload:
|
|
// See: https://developer.github.com/v3/activity/events/types/#pushevent
|
|
webURLs = append(webURLs, payload.Repository.HTMLURL)
|
|
revision = parseRevision(payload.Ref)
|
|
change.shaAfter = parseRevision(payload.After)
|
|
change.shaBefore = parseRevision(payload.Before)
|
|
touchedHead = bool(payload.Repository.DefaultBranch == revision)
|
|
for _, commit := range payload.Commits {
|
|
changedFiles = append(changedFiles, commit.Added...)
|
|
changedFiles = append(changedFiles, commit.Modified...)
|
|
changedFiles = append(changedFiles, commit.Removed...)
|
|
}
|
|
case gitlab.PushEventPayload:
|
|
// See: https://docs.gitlab.com/ee/user/project/integrations/webhooks.html
|
|
webURLs = append(webURLs, payload.Project.WebURL)
|
|
revision = parseRevision(payload.Ref)
|
|
change.shaAfter = parseRevision(payload.After)
|
|
change.shaBefore = parseRevision(payload.Before)
|
|
touchedHead = bool(payload.Project.DefaultBranch == revision)
|
|
for _, commit := range payload.Commits {
|
|
changedFiles = append(changedFiles, commit.Added...)
|
|
changedFiles = append(changedFiles, commit.Modified...)
|
|
changedFiles = append(changedFiles, commit.Removed...)
|
|
}
|
|
case gitlab.TagEventPayload:
|
|
// See: https://docs.gitlab.com/ee/user/project/integrations/webhooks.html
|
|
// NOTE: this is untested
|
|
webURLs = append(webURLs, payload.Project.WebURL)
|
|
revision = parseRevision(payload.Ref)
|
|
change.shaAfter = parseRevision(payload.After)
|
|
change.shaBefore = parseRevision(payload.Before)
|
|
touchedHead = bool(payload.Project.DefaultBranch == revision)
|
|
for _, commit := range payload.Commits {
|
|
changedFiles = append(changedFiles, commit.Added...)
|
|
changedFiles = append(changedFiles, commit.Modified...)
|
|
changedFiles = append(changedFiles, commit.Removed...)
|
|
}
|
|
case bitbucket.RepoPushPayload:
|
|
// See: https://confluence.atlassian.com/bitbucket/event-payloads-740262817.html#EventPayloads-Push
|
|
// NOTE: this is untested
|
|
webURLs = append(webURLs, payload.Repository.Links.HTML.Href)
|
|
// TODO: bitbucket includes multiple changes as part of a single event.
|
|
// We only pick the first but need to consider how to handle multiple
|
|
for _, change := range payload.Push.Changes {
|
|
revision = change.New.Name
|
|
break
|
|
}
|
|
// Not actually sure how to check if the incoming change affected HEAD just by examining the
|
|
// payload alone. To be safe, we just return true and let the controller check for himself.
|
|
touchedHead = true
|
|
|
|
// Bitbucket does not include a list of changed files anywhere in it's payload
|
|
// so we cannot update changedFiles for this type of payload
|
|
case bitbucketserver.RepositoryReferenceChangedPayload:
|
|
|
|
// Webhook module does not parse the inner links
|
|
if payload.Repository.Links != nil {
|
|
for _, l := range payload.Repository.Links["clone"].([]interface{}) {
|
|
link := l.(map[string]interface{})
|
|
if link["name"] == "http" {
|
|
webURLs = append(webURLs, link["href"].(string))
|
|
}
|
|
if link["name"] == "ssh" {
|
|
webURLs = append(webURLs, link["href"].(string))
|
|
}
|
|
}
|
|
}
|
|
|
|
// TODO: bitbucket includes multiple changes as part of a single event.
|
|
// We only pick the first but need to consider how to handle multiple
|
|
for _, change := range payload.Changes {
|
|
revision = parseRevision(change.Reference.ID)
|
|
break
|
|
}
|
|
// Not actually sure how to check if the incoming change affected HEAD just by examining the
|
|
// payload alone. To be safe, we just return true and let the controller check for himself.
|
|
touchedHead = true
|
|
|
|
// Bitbucket does not include a list of changed files anywhere in it's payload
|
|
// so we cannot update changedFiles for this type of payload
|
|
|
|
case gogsclient.PushPayload:
|
|
webURLs = append(webURLs, payload.Repo.HTMLURL)
|
|
revision = parseRevision(payload.Ref)
|
|
change.shaAfter = parseRevision(payload.After)
|
|
change.shaBefore = parseRevision(payload.Before)
|
|
touchedHead = bool(payload.Repo.DefaultBranch == revision)
|
|
for _, commit := range payload.Commits {
|
|
changedFiles = append(changedFiles, commit.Added...)
|
|
changedFiles = append(changedFiles, commit.Modified...)
|
|
changedFiles = append(changedFiles, commit.Removed...)
|
|
}
|
|
}
|
|
return webURLs, revision, change, touchedHead, changedFiles
|
|
}
|
|
|
|
type changeInfo struct {
|
|
shaBefore string
|
|
shaAfter string
|
|
}
|
|
|
|
// HandleEvent handles webhook events for repo push events
|
|
func (a *ArgoCDWebhookHandler) HandleEvent(payload interface{}) {
|
|
webURLs, revision, change, touchedHead, changedFiles := affectedRevisionInfo(payload)
|
|
// NOTE: the webURL does not include the .git extension
|
|
if len(webURLs) == 0 {
|
|
log.Info("Ignoring webhook event")
|
|
return
|
|
}
|
|
for _, webURL := range webURLs {
|
|
log.Infof("Received push event repo: %s, revision: %s, touchedHead: %v", webURL, revision, touchedHead)
|
|
}
|
|
appIf := a.appClientset.ArgoprojV1alpha1().Applications(a.ns)
|
|
apps, err := appIf.List(context.Background(), metav1.ListOptions{})
|
|
if err != nil {
|
|
log.Warnf("Failed to list applications: %v", err)
|
|
return
|
|
}
|
|
|
|
trackingMethod, err := a.settingsSrc.GetTrackingMethod()
|
|
if err != nil {
|
|
log.Warnf("Failed to get trackingMethod: %v", err)
|
|
return
|
|
}
|
|
appInstanceLabelKey, err := a.settingsSrc.GetAppInstanceLabelKey()
|
|
if err != nil {
|
|
log.Warnf("Failed to get appInstanceLabelKey: %v", err)
|
|
return
|
|
}
|
|
|
|
for _, webURL := range webURLs {
|
|
repoRegexp, err := getWebUrlRegex(webURL)
|
|
if err != nil {
|
|
log.Warnf("Failed to get repoRegexp: %s", err)
|
|
continue
|
|
}
|
|
for _, app := range apps.Items {
|
|
if appRevisionHasChanged(&app, revision, touchedHead) && appUsesURL(&app, webURL, repoRegexp) {
|
|
if appFilesHaveChanged(&app, changedFiles) {
|
|
_, err = argo.RefreshApp(appIf, app.ObjectMeta.Name, v1alpha1.RefreshTypeNormal)
|
|
if err != nil {
|
|
log.Warnf("Failed to refresh app '%s' for controller reprocessing: %v", app.ObjectMeta.Name, err)
|
|
continue
|
|
}
|
|
} else if change.shaBefore != "" && change.shaAfter != "" {
|
|
if err := a.storePreviouslyCachedManifests(&app, change, trackingMethod, appInstanceLabelKey); err != nil {
|
|
log.Warnf("Failed to store cached manifests of previous revision for app '%s': %v", app.Name, err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// getWebUrlRegex compiles a regex that will match any targetRevision referring to the same repo as the given webURL.
|
|
// webURL is expected to be a URL from an SCM webhook payload pointing to the web page for the repo.
|
|
func getWebUrlRegex(webURL string) (*regexp.Regexp, error) {
|
|
urlObj, err := url.Parse(webURL)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to parse repoURL '%s'", webURL)
|
|
}
|
|
|
|
regexEscapedHostname := regexp.QuoteMeta(urlObj.Hostname())
|
|
regexEscapedPath := regexp.QuoteMeta(urlObj.Path[1:])
|
|
regexpStr := fmt.Sprintf(`(?i)^(http://|https://|\w+@|ssh://(\w+@)?)%s(:[0-9]+|)[:/]%s(\.git)?$`, regexEscapedHostname, regexEscapedPath)
|
|
repoRegexp, err := regexp.Compile(regexpStr)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to compile regexp for repoURL '%s'", webURL)
|
|
}
|
|
|
|
return repoRegexp, nil
|
|
}
|
|
|
|
func (a *ArgoCDWebhookHandler) storePreviouslyCachedManifests(app *v1alpha1.Application, change changeInfo, trackingMethod string, appInstanceLabelKey string) error {
|
|
err := argo.ValidateDestination(context.Background(), &app.Spec.Destination, a.db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
var clusterInfo v1alpha1.ClusterInfo
|
|
err = a.serverCache.GetClusterInfo(app.Spec.Destination.Server, &clusterInfo)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
cache.LogDebugManifestCacheKeyFields("getting manifests cache", "webhook app revision changed", change.shaBefore, &app.Spec.Source, &clusterInfo, app.Spec.Destination.Namespace, trackingMethod, appInstanceLabelKey, app.Name)
|
|
|
|
var cachedManifests cache.CachedManifestResponse
|
|
if err := a.repoCache.GetManifests(change.shaBefore, &app.Spec.Source, &clusterInfo, app.Spec.Destination.Namespace, trackingMethod, appInstanceLabelKey, app.Name, &cachedManifests); err != nil {
|
|
return err
|
|
}
|
|
|
|
cache.LogDebugManifestCacheKeyFields("setting manifests cache", "webhook app revision changed", change.shaAfter, &app.Spec.Source, &clusterInfo, app.Spec.Destination.Namespace, trackingMethod, appInstanceLabelKey, app.Name)
|
|
|
|
if err = a.repoCache.SetManifests(change.shaAfter, &app.Spec.Source, &clusterInfo, app.Spec.Destination.Namespace, trackingMethod, appInstanceLabelKey, app.Name, &cachedManifests); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func getAppRefreshPaths(app *v1alpha1.Application) []string {
|
|
var paths []string
|
|
if val, ok := app.Annotations[v1alpha1.AnnotationKeyManifestGeneratePaths]; ok && val != "" {
|
|
for _, item := range strings.Split(val, ";") {
|
|
if item == "" {
|
|
continue
|
|
}
|
|
if filepath.IsAbs(item) {
|
|
item = item[1:]
|
|
} else {
|
|
item = filepath.Clean(filepath.Join(app.Spec.Source.Path, item))
|
|
}
|
|
paths = append(paths, item)
|
|
}
|
|
}
|
|
return paths
|
|
}
|
|
|
|
func appFilesHaveChanged(app *v1alpha1.Application, changedFiles []string) bool {
|
|
// an empty slice of changed files means that the payload didn't include a list
|
|
// of changed files and w have to assume that a refresh is required
|
|
if len(changedFiles) == 0 {
|
|
return true
|
|
}
|
|
|
|
// Check to see if the app has requested refreshes only on a specific prefix
|
|
refreshPaths := getAppRefreshPaths(app)
|
|
|
|
if len(refreshPaths) == 0 {
|
|
// Apps without a given refreshed paths always be refreshed, regardless of changed files
|
|
// this is the "default" behavior
|
|
return true
|
|
}
|
|
|
|
// At last one changed file must be under refresh path
|
|
for _, f := range changedFiles {
|
|
f = ensureAbsPath(f)
|
|
for _, item := range refreshPaths {
|
|
item = ensureAbsPath(item)
|
|
changed := false
|
|
if f == item {
|
|
changed = true
|
|
} else if _, err := security.EnforceToCurrentRoot(item, f); err == nil {
|
|
changed = true
|
|
}
|
|
if changed {
|
|
log.WithField("application", app.Name).Debugf("Application uses files that have changed")
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
|
|
log.WithField("application", app.Name).Debugf("Application does not use any of the files that have changed")
|
|
return false
|
|
}
|
|
|
|
func ensureAbsPath(input string) string {
|
|
if !filepath.IsAbs(input) {
|
|
return string(filepath.Separator) + input
|
|
}
|
|
return input
|
|
}
|
|
|
|
func appRevisionHasChanged(app *v1alpha1.Application, revision string, touchedHead bool) bool {
|
|
targetRev := parseRevision(app.Spec.Source.TargetRevision)
|
|
if targetRev == "HEAD" || targetRev == "" { // revision is head
|
|
return touchedHead
|
|
}
|
|
targetRevisionHasPrefixList := []string{"refs/heads/", "refs/tags/"}
|
|
for _, prefix := range targetRevisionHasPrefixList {
|
|
if strings.HasPrefix(app.Spec.Source.TargetRevision, prefix) {
|
|
return revision == targetRev
|
|
}
|
|
}
|
|
|
|
return app.Spec.Source.TargetRevision == revision
|
|
}
|
|
|
|
func appUsesURL(app *v1alpha1.Application, webURL string, repoRegexp *regexp.Regexp) bool {
|
|
if !repoRegexp.MatchString(app.Spec.Source.RepoURL) {
|
|
log.Debugf("%s does not match %s", app.Spec.Source.RepoURL, repoRegexp.String())
|
|
return false
|
|
}
|
|
|
|
log.Debugf("%s uses repoURL %s", app.Spec.Source.RepoURL, webURL)
|
|
return true
|
|
}
|
|
|
|
func (a *ArgoCDWebhookHandler) Handler(w http.ResponseWriter, r *http.Request) {
|
|
|
|
var payload interface{}
|
|
var err error
|
|
|
|
switch {
|
|
//Gogs needs to be checked before GitHub since it carries both Gogs and (incompatible) GitHub headers
|
|
case r.Header.Get("X-Gogs-Event") != "":
|
|
payload, err = a.gogs.Parse(r, gogs.PushEvent)
|
|
if errors.Is(err, gogs.ErrHMACVerificationFailed) {
|
|
log.WithField(common.SecurityField, common.SecurityHigh).Infof("Gogs webhook HMAC verification failed")
|
|
}
|
|
case r.Header.Get("X-GitHub-Event") != "":
|
|
payload, err = a.github.Parse(r, github.PushEvent, github.PingEvent)
|
|
if errors.Is(err, github.ErrHMACVerificationFailed) {
|
|
log.WithField(common.SecurityField, common.SecurityHigh).Infof("GitHub webhook HMAC verification failed")
|
|
}
|
|
case r.Header.Get("X-Gitlab-Event") != "":
|
|
payload, err = a.gitlab.Parse(r, gitlab.PushEvents, gitlab.TagEvents)
|
|
if errors.Is(err, gitlab.ErrGitLabTokenVerificationFailed) {
|
|
log.WithField(common.SecurityField, common.SecurityHigh).Infof("GitLab webhook token verification failed")
|
|
}
|
|
case r.Header.Get("X-Hook-UUID") != "":
|
|
payload, err = a.bitbucket.Parse(r, bitbucket.RepoPushEvent)
|
|
if errors.Is(err, bitbucket.ErrUUIDVerificationFailed) {
|
|
log.WithField(common.SecurityField, common.SecurityHigh).Infof("BitBucket webhook UUID verification failed")
|
|
}
|
|
case r.Header.Get("X-Event-Key") != "":
|
|
payload, err = a.bitbucketserver.Parse(r, bitbucketserver.RepositoryReferenceChangedEvent, bitbucketserver.DiagnosticsPingEvent)
|
|
if errors.Is(err, bitbucketserver.ErrHMACVerificationFailed) {
|
|
log.WithField(common.SecurityField, common.SecurityHigh).Infof("BitBucket webhook HMAC verification failed")
|
|
}
|
|
default:
|
|
log.Debug("Ignoring unknown webhook event")
|
|
http.Error(w, "Unknown webhook event", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
if err != nil {
|
|
log.Infof("Webhook processing failed: %s", err)
|
|
status := http.StatusBadRequest
|
|
if r.Method != "POST" {
|
|
status = http.StatusMethodNotAllowed
|
|
}
|
|
http.Error(w, fmt.Sprintf("Webhook processing failed: %s", html.EscapeString(err.Error())), status)
|
|
return
|
|
}
|
|
|
|
a.HandleEvent(payload)
|
|
}
|