2.6 KiB
Managing Dependencies
Notifications Engine (github.com/argoproj/notifications-engine)
Repository
Pulling changes from notifications-engine
After your Notifications Engine PR has been merged, ArgoCD needs to be updated to pull in the version of the notifications engine that contains your change. Here are the steps:
-
Retrieve the SHA hash for your commit. You will use this in the next step.
-
From the
argo-cdfolder, run the following commandgo get github.com/argoproj/notifications-engine@<git-commit-sha>If you get an error message
invalid version: unknown revisionthen you got the wrong SHA hash -
Run:
go mod tidy -
The following files are changed:
go.modgo.sum
-
If your notifications engine PR included docs changes, run
make codegenormake codegen-local. -
Create an ArgoCD PR with a
chore:type in its title for the above file changes.
Argo UI Components (github.com/argoproj/argo-ui)
Contributing to Argo CD UI
Argo CD, along with Argo Workflows, uses shared React components from Argo UI. Examples of some of these components include buttons, containers, form controls, and others. Although you can make changes to these files and run them locally, in order to have these changes added to the Argo CD repo, you will need to follow these steps.
-
Fork and clone the Argo UI repository.
-
cdinto yourargo-uidirectory, and then runyarn install. -
Make your file changes.
-
Run
yarn startto start a storybook dev server and view the components in your browser. Make sure all your changes work as expected. -
Use yarn link to link Argo UI package to your Argo CD repository. (Commands below assume that
argo-uiandargo-cdare both located within the same parent folder)cd argo-uiyarn linkcd ../argo-cd/uiyarn link argo-ui
Once the
argo-uipackage has been successfully linked, test changes in your local development environment. -
Commit changes and open a PR to Argo UI.
-
Once your PR has been merged in Argo UI,
cdinto yourargo-cd/uifolder and runyarn add git+https://github.com/argoproj/argo-ui.git. This will update the commit SHA in theui/yarn.lockfile to use the latest master commit for argo-ui. -
Submit changes to
ui/yarn.lockin a PR to Argo CD.