marcel/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd.git synced 2026-02-20 01:28:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve flaky TestSync_SyncWaveHookError test (#26080)

Browse Source 
Signed-off-by: Aditya Raj <adityaraj10600@gmail.com>
This commit is contained in:
Aditya Raj
2026-01-21 12:49:39 +05:30
committed by GitHub
parent c879b6da2f
commit 2f7d36bc38
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gitops-engine/pkg/sync/sync_context_test.go
View File

@@ -1981,12 +1981,12 @@ func TestSync_SyncWaveHookError(t *testing.T) {
phase, msg, results := syncCtx.GetState()
assert.Equal(t, synccommon.OperationError, phase)
assert.Equal(t, "SyncWaveHook failed: intentional error", msg)
assert.Equal(t, synccommon.OperationRunning, results[0].HookPhase)
require.Len(t, results, 2)
podResult := getResourceResult(results, kube.GetResourceKey(pod1))
require.NotNil(t, podResult, "%s not found", kube.GetResourceKey(pod1))
assert.Equal(t, synccommon.OperationRunning, podResult.HookPhase)
// Hook phase can be either Running or Succeeded due to timing, what matters is the operation failed
assert.Contains(t, []synccommon.OperationPhase{synccommon.OperationRunning, synccommon.OperationSucceeded}, podResult.HookPhase)
hookResult := getResourceResult(results, kube.GetResourceKey(syncHook))
require.NotNil(t, hookResult, "%s not found", kube.GetResourceKey(syncHook))