fix(rbac): Add rights on applicationsets for the application controller (#20352)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>

docs/operator-manual/installation.md

@@ -31,6 +31,10 @@ Not recommended for production use. This type of installation is typically used
   Argo CD instances for different teams, where each instance will be deploying applications to
   external clusters. It will still be possible to deploy to the same cluster (kubernetes.svc.default)
   with inputted credentials (i.e. `argocd cluster add <CONTEXT> --in-cluster --namespace <YOUR NAMESPACE>`).
+  With the default roles included, you will only be able to deploy Argo CD resources (Applications, ApplicationSets
+  and AppProjects)  in the same cluster, as it's only supporting the GitOps mode with real deployments being
+  done to external clusters.
+  You can modify that by defining new roles and binding them to the `argocd-application-controller` service account.
 
   > Note: Argo CD CRDs are not included into [namespace-install.yaml](https://github.com/argoproj/argo-cd/blob/master/manifests/namespace-install.yaml).
   > and have to be installed separately. The CRD manifests are located in the [manifests/crds](https://github.com/argoproj/argo-cd/blob/master/manifests/crds) directory.

manifests/base/application-controller-roles/argocd-application-controller-role.yaml

@@ -20,6 +20,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create

manifests/core-install-with-hydrator.yaml

@@ -23626,6 +23626,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create

manifests/core-install.yaml

@@ -23617,6 +23617,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create

manifests/ha/install-with-hydrator.yaml

@@ -23664,6 +23664,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create

manifests/ha/install.yaml

@@ -23655,6 +23655,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create

manifests/ha/namespace-install-with-hydrator.yaml

@@ -104,6 +104,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create

manifests/ha/namespace-install.yaml

@@ -95,6 +95,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create

manifests/install-with-hydrator.yaml

@@ -23653,6 +23653,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create

manifests/install.yaml

@@ -23644,6 +23644,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create

manifests/namespace-install-with-hydrator.yaml

@@ -93,6 +93,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create

manifests/namespace-install.yaml

@@ -84,6 +84,7 @@ rules:
   - argoproj.io
   resources:
   - applications
+  - applicationsets
   - appprojects
   verbs:
   - create