marcel/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd.git synced 2026-02-20 01:28:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: remove unused reposFilter from Applications list (#24667)

Browse Source 
Signed-off-by: choejwoo <jaewoo45@gmail.com>
This commit is contained in:
Jaewoo Choi
2026-02-07 05:20:50 +09:00
committed by GitHub
parent 2e1d81d62c
commit f85ad11b2a
2 changed files with 1 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ui/src/app/applications/components/applications-list/applications-filter.tsx
View File

@@ -17,12 +17,11 @@ import {
import {AppsListPreferences, AppSetsListPreferences, services} from '../../../shared/services';
import {Filter, FiltersGroup} from '../filter/filter';
import {createMetadataSelector} from '../selectors';
import {ComparisonStatusIcon, getAppDefaultSource, getAppSetHealthStatus, HealthStatusIcon, getOperationStateTitle} from '../utils';
import {ComparisonStatusIcon, getAppSetHealthStatus, HealthStatusIcon, getOperationStateTitle} from '../utils';
import {formatClusterQueryParam} from '../../../shared/utils';
import {COLORS} from '../../../shared/components/colors';
export interface FilterResult {
repos: boolean;
sync: boolean;
autosync: boolean;
health: boolean;
@@ -63,7 +62,6 @@ export function getAppFilterResults(applications: Application[], pref: AppsListP
return applications.map(app => ({
...app,
filterResult: {
repos: pref.reposFilter.length === 0 || pref.reposFilter.includes(getAppDefaultSource(app).repoURL),
sync: pref.syncFilter.length === 0 || pref.syncFilter.includes(app.status.sync.status),
autosync: pref.autoSyncFilter.length === 0 || pref.autoSyncFilter.includes(getAutoSyncStatus(app.spec.syncPolicy)),
health: pref.healthFilter.length === 0 || pref.healthFilter.includes(app.status.health.status),

31
ui/src/app/shared/services/view-preferences-service.ts
View File

@@ -86,39 +86,18 @@ export class AbstractAppsListPreferences {
}
export class AppsListPreferences extends AbstractAppsListPreferences {
public static countEnabledFilters(pref: AppsListPreferences) {
return [
pref.clustersFilter,
pref.healthFilter,
pref.labelsFilter,
pref.annotationsFilter,
pref.namespacesFilter,
pref.projectsFilter,
pref.reposFilter,
pref.syncFilter,
pref.operationFilter
].reduce((count, filter) => {
if (filter && filter.length > 0) {
return count + 1;
}
return count;
}, 0);
}
public static clearFilters(pref: AppsListPreferences) {
super.clearFilters(pref);
pref.clustersFilter = [];
pref.namespacesFilter = [];
pref.projectsFilter = [];
pref.reposFilter = [];
pref.syncFilter = [];
pref.autoSyncFilter = [];
pref.operationFilter = [];
}
public projectsFilter: string[];
public reposFilter: string[];
public syncFilter: string[];
public autoSyncFilter: string[];
public namespacesFilter: string[];
@@ -127,15 +106,6 @@ export class AppsListPreferences extends AbstractAppsListPreferences {
}
export class AppSetsListPreferences extends AbstractAppsListPreferences {
public static countEnabledFilters(pref: AppSetsListPreferences) {
return [pref.healthFilter, pref.labelsFilter].reduce((count, filter) => {
if (filter && filter.length > 0) {
return count + 1;
}
return count;
}, 0);
}
public static clearFilters(pref: AppSetsListPreferences) {
super.clearFilters(pref);
}
@@ -187,7 +157,6 @@ const DEFAULT_PREFERENCES: ViewPreferences = {
projectsFilter: new Array<string>(),
namespacesFilter: new Array<string>(),
clustersFilter: new Array<string>(),
reposFilter: new Array<string>(),
syncFilter: new Array<string>(),
autoSyncFilter: new Array<string>(),
healthFilter: new Array<string>(),