marcel/argo-cd
1
0
Fork 0
mirror of https://github.com/argoproj/argo-cd.git synced 2026-02-20 01:28:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct typos across codebase (#25959)

Browse Source 
Signed-off-by: Ekene Chris <ekenechris53@gmail.com>
This commit is contained in:
Ekene Chris
2026-01-14 14:54:34 +01:00
committed by GitHub
parent c212bb77bd
commit bde6f667e1
11 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
applicationset/generators/git.go
View File

@@ -316,7 +316,7 @@ func (g *GitGenerator) filterApps(directories []argoprojiov1alpha1.GitDirectoryG
appExclude = true
}
}
// Whenever there is a path with exclude: true it wont be included, even if it is included in a different path pattern
// Whenever there is a path with exclude: true it won't be included, even if it is included in a different path pattern
if appInclude && !appExclude {
res = append(res, appPath)
}

2
docs/operator-manual/ingress.md
View File

@@ -415,7 +415,7 @@ apiVersion: v1
kind: Service
metadata:
annotations:
alb.ingress.kubernetes.io/backend-protocol-version: GRPC # This tells AWS to send traffic from the ALB using GRPC. Plain HTTP2 can be used, but the health checks wont be available because argo currently downgrade non-grpc calls to HTTP1
alb.ingress.kubernetes.io/backend-protocol-version: GRPC # This tells AWS to send traffic from the ALB using GRPC. Plain HTTP2 can be used, but the health checks won't be available because argo currently downgrades non-grpc calls to HTTP1
labels:
app: argogrpc
name: argogrpc

2
gitops-engine/pkg/diff/diff_test.go
View File

@@ -704,7 +704,7 @@ func TestNullSecretData(t *testing.T) {
}
// TestRedactedSecretData tests we are able to perform diff on redacted secret data, which has
// invalid characters (*) for the the data byte array field.
// invalid characters (*) for the data byte array field.
func TestRedactedSecretData(t *testing.T) {
configUn := unmarshalFile("testdata/wordpress-config.json")
liveUn := unmarshalFile("testdata/wordpress-live.json")

2
gitops-engine/pkg/utils/kube/resource_ops.go
View File

@@ -119,7 +119,7 @@ func (k *kubectlResourceOperations) runResourceCommand(ctx context.Context, obj
defer io.DeleteFile(manifestFile.Name())
var out []string
// rbac resouces are first applied with auth reconcile kubectl feature.
// rbac resources are first applied with auth reconcile kubectl feature.
if obj.GetAPIVersion() == "rbac.authorization.k8s.io/v1" {
outReconcile, err := k.rbacReconcile(ctx, obj, manifestFile.Name(), dryRunStrategy)
if err != nil {

8
resource_customizations/batch/CronJob/health.lua
View File

@@ -1,7 +1,7 @@
hs = {}
if obj.spec.suspend == true then
-- Set to Healthy insted of Suspended until bug is resolved
-- Set to Healthy instead of Suspended until bug is resolved
-- See https://github.com/argoproj/argo-cd/issues/24428
hs.status = "Healthy"
hs.message = "CronJob is Suspended"
@@ -13,15 +13,15 @@ if obj.status ~= nil then
-- Job is running its first execution and has not yet reported any success
if obj.status.lastSuccessfulTime == nil then
-- Set to healthy even if it may be degraded, because we dont know
-- Set to healthy even if it may be degraded, because we don't know
-- if it was not yet executed or if it never succeeded
hs.status = "Healthy"
hs.message = "The Cronjob never completed succesfully. It may not be healthy"
hs.message = "The CronJob never completed successfully. It may not be healthy"
return hs
end
-- Job is progressing, so lastScheduleTime will always be grater than lastSuccessfulTime
-- Job is progressing, so lastScheduleTime will always be greater than lastSuccessfulTime
-- Set to healthy since we do not know if it is Degraded
-- See https://github.com/argoproj/argo-cd/issues/24429
if obj.status.active ~= nil and table.getn(obj.status.active) > 0 then

2
resource_customizations/batch/CronJob/health_test.yaml
View File

@@ -13,7 +13,7 @@ tests:
inputPath: testdata/degraded.yaml
- healthStatus:
status: Healthy
message: The Cronjob never completed succesfully. It may not be healthy
message: The CronJob never completed successfully. It may not be healthy
inputPath: testdata/never-succeeded.yaml
- healthStatus:
status: Healthy

2
ui/src/app/applications/components/application-summary/edit-notification-subscriptions.tsx
View File

@@ -53,7 +53,7 @@ export const notificationSubscriptionsParser = {
};
/**
* split the notification subscription related annotation to have it in seperate edit field
* split the notification subscription related annotation to have it in separate edit field
* this hook will emit notification subscription state, controller & merge utility to core annotations helpful when final submit
*/
export const useEditNotificationSubscriptions = (annotations: models.Application['metadata']['annotations']) => {

2
ui/src/app/settings/components/account-details/account-details.tsx
View File

@@ -134,7 +134,7 @@ export const AccountDetails = (props: RouteComponentProps<{name: string}>) => {
}
} catch (e) {
ctx.notifications.show({
content: <ErrorNotification title='Unable to delete token token' e={e} />,
content: <ErrorNotification title='Unable to delete token' e={e} />,
type: NotificationType.Error
});
}

4
util/db/cluster_test.go
View File

@@ -710,7 +710,7 @@ func TestClusterRaceConditionClusterSecrets(t *testing.T) {
cluster, _ := SecretToCluster(clusterSecret)
go func() {
for {
// create a copy so we dont act on the same argo cluster
// create a copy so we don't act on the same argo cluster
clusterCopy := cluster.DeepCopy()
_, _ = db.UpdateCluster(ctx, clusterCopy)
}
@@ -718,7 +718,7 @@ func TestClusterRaceConditionClusterSecrets(t *testing.T) {
// yes, we will take 15 seconds to run this test
// but it reliably triggered the race condition
for i := 0; i < 30; i++ {
// create a copy so we dont act on the same argo cluster
// create a copy so we don't act on the same argo cluster
clusterCopy := cluster.DeepCopy()
_, _ = db.UpdateCluster(ctx, clusterCopy)
time.Sleep(time.Millisecond * 500)

6
util/git/creds.go
View File

@@ -535,7 +535,7 @@ func (g GitHubAppCreds) getInstallationTransport() (*ghinstallation.Transport, e
h := sha256.New()
_, err := fmt.Fprintf(h, "%s %d %d %s", g.privateKey, g.appID, g.appInstallId, g.baseURL)
if err != nil {
return nil, fmt.Errorf("failed to get get SHA256 hash for GitHub app credentials: %w", err)
return nil, fmt.Errorf("failed to get SHA256 hash for GitHub app credentials: %w", err)
}
key := hex.EncodeToString(h.Sum(nil))
@@ -878,7 +878,7 @@ func (c GoogleCloudCreds) getAccessToken() (string, error) {
token, err := ts.Token()
if err != nil {
return "", fmt.Errorf("failed to get get SHA256 hash for Google Cloud credentials: %w", err)
return "", fmt.Errorf("failed to get SHA256 hash for Google Cloud credentials: %w", err)
}
return token.AccessToken, nil
@@ -923,7 +923,7 @@ func (creds AzureWorkloadIdentityCreds) getAccessToken(scope string) (string, er
// Compute hash of creds for lookup in cache
key, err := argoutils.GenerateCacheKey("%s", scope)
if err != nil {
return "", fmt.Errorf("failed to get get SHA256 hash for Azure credentials: %w", err)
return "", fmt.Errorf("failed to get SHA256 hash for Azure credentials: %w", err)
}
t, found := azureTokenCache.Get(key)

4
util/settings/settings_test.go
View File

@@ -2132,7 +2132,7 @@ func TestIsImpersonationEnabled(t *testing.T) {
settingsManager := NewSettingsManager(t.Context(), kubeClient, "default")
featureFlag, err := settingsManager.IsImpersonationEnabled()
require.False(t, featureFlag,
"with no argocd-cm config map, IsImpersonationEnabled() must return return false (default value)")
"with no argocd-cm config map, IsImpersonationEnabled() must return false (default value)")
require.ErrorContains(t, err, "configmap \"argocd-cm\" not found",
"with no argocd-cm config map, IsImpersonationEnabled() must return an error")
@@ -2175,7 +2175,7 @@ func TestRequireOverridePrivilegeForRevisionSyncNoConfigMap(t *testing.T) {
settingsManager := NewSettingsManager(t.Context(), kubeClient, "default")
featureFlag, err := settingsManager.RequireOverridePrivilegeForRevisionSync()
require.False(t, featureFlag,
"with no argocd-cm config map, RequireOverridePrivilegeForRevisionSync() must return return false (default value)")
"with no argocd-cm config map, RequireOverridePrivilegeForRevisionSync() must return false (default value)")
require.ErrorContains(t, err, "configmap \"argocd-cm\" not found",
"with no argocd-cm config map, RequireOverridePrivilegeForRevisionSync() must return an error")
}